use NETFRAMEWORK constant instead of NET472

Author: arturcic

src/GitVersionExe.Tests/Helpers/PathHelper.cs

@@ -13,7 +13,7 @@ public static string GetCurrentDirectory()
 
         public static string GetExecutable()
         {
-#if NET472
+#if NETFRAMEWORK
             var executable = Path.Combine(GetExeDirectory(), "GitVersion.exe");
 #else
         var executable = "dotnet";
@@ -23,7 +23,7 @@ public static string GetExecutable()
 
         public static string GetExecutableArgs(string args)
         {
-#if !NET472
+#if !NETFRAMEWORK
         args = $"{Path.Combine(GetExeDirectory(), "GitVersion.dll")} {args}";
 #endif
             return args;

src/GitVersionTask.MsBuild/LibGit2Sharp/GitLoaderContext.cs

@@ -1,5 +1,5 @@
 // This code originally copied from https://raw.githubusercontent.com/dotnet/sourcelink/master/src/Microsoft.Build.Tasks.Git/GitLoaderContext.cs
-#if !NET472
+#if !NETFRAMEWORK
 using System;
 using System.IO;
 using System.Linq;

src/GitVersionTask.MsBuild/LibGit2Sharp/LibGit2SharpLoader.cs

@@ -19,7 +19,7 @@ public class LibGit2SharpLoader
         private LibGit2SharpLoader(string tasksAssembly)
         {
             taskDirectory = Path.GetDirectoryName(typeof(LibGit2SharpLoader).Assembly.Location);
-#if NET472
+#if NETFRAMEWORK
             nullVersion = new Version(0, 0, 0, 0);
             loaderLog = new List<string>();
 
@@ -34,7 +34,7 @@ private LibGit2SharpLoader(string tasksAssembly)
 #endif
         }
 
-#if NET472
+#if NETFRAMEWORK
 
         private static Version nullVersion;
 

src/GitVersionTask.MsBuild/LibGit2Sharp/RuntimeIdMap.cs

@@ -1,5 +1,5 @@
 // This code originally copied from https://raw.githubusercontent.com/dotnet/sourcelink/master/src/Microsoft.Build.Tasks.Git/RuntimeIdMap.cs
-#if !NET472
+#if !NETFRAMEWORK
 using System;
 using System.Diagnostics;
 
@@ -48,14 +48,14 @@ void FindBestCandidate(int startIndex, int increment)
 
                         // Find the highest available version that is lower than or equal to the runtime version
                         // among candidates that have the same qualifiers.
-                        if (candidateQualifiers == runtimeQualifiers && 
-                            CompareVersions(candidateVersion, runtimeVersion) <= 0 && 
+                        if (candidateQualifiers == runtimeQualifiers &&
+                            CompareVersions(candidateVersion, runtimeVersion) <= 0 &&
                             (bestVersion == null || CompareVersions(candidateVersion, bestVersion) > 0))
                         {
                             bestMatchIndex = i;
                             bestVersion = candidateVersion;
                         }
-                        
+
                         i += increment;
                     }
                 }
@@ -105,7 +105,7 @@ internal static int CompareVersions(string[] left, string[] right)
 
         internal static void ParseRuntimeId(string runtimeId, out string osName, out string[] version, out string qualifiers)
         {
-            // We use the following convention in all newly-defined RIDs. Some RIDs (win7-x64, win8-x64) predate this convention and don't follow it, but all new RIDs should follow it. 
+            // We use the following convention in all newly-defined RIDs. Some RIDs (win7-x64, win8-x64) predate this convention and don't follow it, but all new RIDs should follow it.
             // [os name].[version]-[architecture]-[additional qualifiers]
             // See https://github.com/dotnet/corefx/blob/master/pkg/Microsoft.NETCore.Platforms/readme.md#naming-convention
 

src/GitVersionTask.MsBuild/TaskProxy.cs

@@ -14,7 +14,7 @@ public static class TaskProxy
 
         static TaskProxy()
         {
-#if !NET472
+#if !NETFRAMEWORK
             GitLoaderContext.Init("GitVersionCore", "LibGit2Sharp");
 #endif
             LibGit2SharpLoader.LoadAssembly("GitVersionTask");