caches git objects correctly

Caches git objects using canonical names for better performance.

Author: arturcic

src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

@@ -12,6 +12,8 @@ internal sealed partial class GitRepository
     private readonly ConcurrentDictionary<string, Branch> cachedBranches = new();
     private readonly ConcurrentDictionary<string, Commit> cachedCommits = new();
     private readonly ConcurrentDictionary<string, Tag> cachedTags = new();
+    private readonly ConcurrentDictionary<string, Reference> cachedReferences = new();
+    private readonly ConcurrentDictionary<string, Remote> cachedRemotes = new();
 
     private IRepository RepositoryInstance
     {
@@ -28,10 +30,10 @@ private IRepository RepositoryInstance
     public IBranch Head => GetOrWrap(RepositoryInstance.Head, RepositoryInstance.Diff);
 
     public ITagCollection Tags => new TagCollection(RepositoryInstance.Tags, RepositoryInstance.Diff, this);
-    public IReferenceCollection Refs => new ReferenceCollection(RepositoryInstance.Refs);
+    public IReferenceCollection Refs => new ReferenceCollection(RepositoryInstance.Refs, this);
     public IBranchCollection Branches => new BranchCollection(RepositoryInstance.Branches, RepositoryInstance.Diff, this);
     public ICommitCollection Commits => new CommitCollection(RepositoryInstance.Commits, RepositoryInstance.Diff, this);
-    public IRemoteCollection Remotes => new RemoteCollection(RepositoryInstance.Network.Remotes);
+    public IRemoteCollection Remotes => new RemoteCollection(RepositoryInstance.Network.Remotes, this);
 
     public void DiscoverRepository(string? gitDirectory)
     {
@@ -77,6 +79,12 @@ public Commit GetOrWrap(LibGit2Sharp.Commit innerCommit, Diff repoDiff)
     public Tag GetOrWrap(LibGit2Sharp.Tag innerTag, Diff repoDiff)
         => cachedTags.GetOrAdd(innerTag.CanonicalName, _ => new Tag(innerTag, repoDiff, this));
 
+    public Reference GetOrWrap(LibGit2Sharp.Reference innerReference)
+        => cachedReferences.GetOrAdd(innerReference.CanonicalName, _ => new Reference(innerReference));
+
+    public Remote GetOrWrap(LibGit2Sharp.Remote innerRemote)
+        => cachedRemotes.GetOrAdd(innerRemote.Name, _ => new Remote(innerRemote));
+
     public void Dispose()
     {
         if (this.repositoryLazy is { IsValueCreated: true }) RepositoryInstance.Dispose();

src/GitVersion.LibGit2Sharp/Git/ReferenceCollection.cs

@@ -5,19 +5,22 @@ namespace GitVersion.Git;
 internal sealed class ReferenceCollection : IReferenceCollection
 {
     private readonly LibGit2Sharp.ReferenceCollection innerCollection;
+    private readonly GitRepository repo;
     private readonly Lazy<IReadOnlyCollection<IReference>> references;
 
-    internal ReferenceCollection(LibGit2Sharp.ReferenceCollection collection)
+    internal ReferenceCollection(LibGit2Sharp.ReferenceCollection collection, GitRepository repo)
     {
         this.innerCollection = collection.NotNull();
-        this.references = new Lazy<IReadOnlyCollection<IReference>>(() => [.. this.innerCollection.Select(reference => new Reference(reference))]);
+        this.repo = repo.NotNull();
+        this.references = new Lazy<IReadOnlyCollection<IReference>>(() => [.. this.innerCollection.Select(repo.GetOrWrap)]);
     }
 
     public IEnumerator<IReference> GetEnumerator() => this.references.Value.GetEnumerator();
 
     IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 
-    public void Add(string name, string canonicalRefNameOrObject, bool allowOverwrite = false) => this.innerCollection.Add(name, canonicalRefNameOrObject, allowOverwrite);
+    public void Add(string name, string canonicalRefNameOrObject, bool allowOverwrite = false)
+        => this.innerCollection.Add(name, canonicalRefNameOrObject, allowOverwrite);
 
     public void UpdateTarget(IReference directRef, IObjectId targetId)
         => RepositoryExtensions.RunSafe(() => this.innerCollection.UpdateTarget((Reference)directRef, (ObjectId)targetId));
@@ -27,13 +30,13 @@ public IReference? this[string name]
         get
         {
             var reference = this.innerCollection[name];
-            return reference is null ? null : new Reference(reference);
+            return reference is null ? null : this.repo.GetOrWrap(reference);
         }
     }
 
     public IReference? this[ReferenceName referenceName] => this[referenceName.Canonical];
 
     public IReference? Head => this["HEAD"];
 
-    public IEnumerable<IReference> FromGlob(string prefix) => this.innerCollection.FromGlob(prefix).Select(reference => (IReference)new Reference(reference));
+    public IEnumerable<IReference> FromGlob(string prefix) => this.innerCollection.FromGlob(prefix).Select(reference => (IReference)this.repo.GetOrWrap(reference));
 }

src/GitVersion.LibGit2Sharp/Git/Remote.cs

@@ -17,7 +17,7 @@ namespace GitVersion.Git;
     public string Name => this.innerRemote.Name;
     public string Url => this.innerRemote.Url;
 
-    public IEnumerable<IRefSpec> RefSpecs
+    private IEnumerable<IRefSpec> RefSpecs
     {
         get
         {

src/GitVersion.LibGit2Sharp/Git/RemoteCollection.cs

@@ -5,12 +5,14 @@ namespace GitVersion.Git;
 internal sealed class RemoteCollection : IRemoteCollection
 {
     private readonly LibGit2Sharp.RemoteCollection innerCollection;
+    private readonly GitRepository repo;
     private readonly Lazy<IReadOnlyCollection<IRemote>> remotes;
 
-    internal RemoteCollection(LibGit2Sharp.RemoteCollection collection)
+    internal RemoteCollection(LibGit2Sharp.RemoteCollection collection, GitRepository repo)
     {
         this.innerCollection = collection.NotNull();
-        this.remotes = new Lazy<IReadOnlyCollection<IRemote>>(() => [.. this.innerCollection.Select(reference => new Remote(reference))]);
+        this.repo = repo.NotNull();
+        this.remotes = new Lazy<IReadOnlyCollection<IRemote>>(() => [.. this.innerCollection.Select(repo.GetOrWrap)]);
     }
 
     public IEnumerator<IRemote> GetEnumerator() => this.remotes.Value.GetEnumerator();
@@ -22,7 +24,7 @@ public IRemote? this[string name]
         get
         {
             var remote = this.innerCollection[name];
-            return remote is null ? null : new Remote(remote);
+            return remote is null ? null : this.repo.GetOrWrap(remote);
         }
     }