Removed config file related code (will be read from working directory, not git dir), and no longer delete dynamic repo once done.

Author: JakeGinnivan

GitVersionExe.Tests/GitPreparerTests.cs

@@ -20,11 +20,9 @@ public GitPreparerTests()
     const string SpecificBranchName = "feature/foo";
 
     [Test]
-    [TestCase(null, DefaultBranchName, false)]
-    [TestCase(SpecificBranchName, SpecificBranchName, false)]
-    [TestCase(null, DefaultBranchName, true)]
-    [TestCase(SpecificBranchName, SpecificBranchName, true)]
-    public void WorksCorrectlyWithRemoteRepository(string branchName, string expectedBranchName, bool checkConfig)
+    [TestCase(null, DefaultBranchName)]
+    [TestCase(SpecificBranchName, SpecificBranchName)]
+    public void WorksCorrectlyWithRemoteRepository(string branchName, string expectedBranchName)
     {
         var repoName = Guid.NewGuid().ToString();
         var tempPath = Path.GetTempPath();
@@ -41,22 +39,8 @@ public void WorksCorrectlyWithRemoteRepository(string branchName, string expecte
                 fixture.Repository.MakeCommits(5);
                 fixture.Repository.CreateFileAndCommit("TestFile.txt");
 
-                if (checkConfig)
-                {
-                    fixture.Repository.CreateFileAndCommit("GitVersionConfig.yaml");
-                }
-
                 fixture.Repository.CreateBranch(SpecificBranchName);
 
-                if (checkConfig)
-                {
-                    fixture.Repository.Refs.UpdateTarget(fixture.Repository.Refs.Head, fixture.Repository.Refs["refs/heads/" + SpecificBranchName]);
-
-                    fixture.Repository.CreateFileAndCommit("GitVersionConfig.yaml");
-
-                    fixture.Repository.Refs.UpdateTarget(fixture.Repository.Refs.Head, fixture.Repository.Refs["refs/heads/" + DefaultBranchName]);
-                }
-
                 var arguments = new Arguments
                 {
                     TargetPath = tempDir,
@@ -83,12 +67,6 @@ public void WorksCorrectlyWithRemoteRepository(string branchName, string expecte
                     var currentBranch = repository.Head.CanonicalName;
 
                     currentBranch.EndsWith(expectedBranchName).ShouldBe(true);
-
-                    if (checkConfig)
-                    {
-                        var expectedConfigPath = Path.Combine(dynamicRepositoryPath, "..\\GitVersionConfig.yaml");
-                        File.Exists(expectedConfigPath).ShouldBe(true);
-                    }
                 }
             }
         }

GitVersionExe/GitPreparer.cs

@@ -85,9 +85,9 @@ static string CreateDynamicRepository(string targetPath, Authentication authenti
             var gitDirectory = Path.Combine(targetPath, ".git");
             if (Directory.Exists(targetPath))
             {
-                Logger.WriteInfo(string.Format("Deleting existing .git folder from '{0}' to force new checkout from url", targetPath));
+                Logger.WriteInfo("Git repository already exists at {0}, skipping clone");
 
-                DeleteHelper.DeleteGitRepository(targetPath);
+                return gitDirectory;
             }
 
             Credentials credentials = null;
@@ -150,9 +150,6 @@ static string CreateDynamicRepository(string targetPath, Authentication authenti
 
                     repository.Refs.UpdateTarget(repository.Refs.Head, newHead);
                 }
-
-                // > 3.0 method
-                repository.CheckoutFilesIfExist("GitVersionConfig.yaml");
             }
 
             return gitDirectory;

GitVersionExe/SpecifiedArgumentRunner.cs

@@ -79,11 +79,6 @@ public static void Run(Arguments arguments, IFileSystem fileSystem)
                     //}
                 }
             }
-
-            if (gitPreparer.IsDynamicGitRepository)
-            {
-                DeleteHelper.DeleteGitRepository(gitPreparer.DynamicGitRepositoryPath);
-            }
         }
 
         static IEnumerable<IBuildServer> GetApplicableBuildServers(Authentication authentication)