Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2017 package build include gitversiontask as a dependency #1188

Closed
roryprimrose opened this issue Mar 15, 2017 · 3 comments
Closed

VS2017 package build include gitversiontask as a dependency #1188

roryprimrose opened this issue Mar 15, 2017 · 3 comments

Comments

@roryprimrose
Copy link

I have a new VS2017 project that targets netstandard1.3, builds a nuget package on compile and defines the following dependencies:

  <ItemGroup>
    <PackageReference Include="Ensure.That" Version="5.0.0" />
    <PackageReference Include="gitversiontask" Version="4.0.0-beta0011" />
    <PackageReference Include="nodatime" Version="2.0.0-beta20170123" />
  </ItemGroup>

The nuspec included in the nupkg then contains the following dependencies:

    <dependencies>
      <group targetFramework=".NETStandard1.3">
        <dependency id="gitversiontask" version="4.0.0-beta0011" exclude="Build,Analyzers" />
        <dependency id="NETStandard.Library" version="1.6.1" exclude="Build,Analyzers" />
        <dependency id="nodatime" version="2.0.0-beta20170123" exclude="Build,Analyzers" />
        <dependency id="Ensure.That" version="5.0.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>

This would result in gitversiontask being installed into any project that consumes this package. Is there an equivalent version of the development dependency flag that there was in the VS2015 world?

@roryprimrose
Copy link
Author

roryprimrose commented Mar 15, 2017

I suspect this is a bug in NuGet as the nuspec of GitVersionTask contains the development dependency flag

https://github.com/GitTools/GitVersion/blob/master/src/GitVersionTask/NugetAssets/GitVersionTask.nuspec#L16

@roryprimrose
Copy link
Author

This has already been raised by @onovotny at NuGet/Home#4125

@tofutim
Copy link
Contributor

tofutim commented Jun 8, 2017

Has this been resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants