Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitVersionApp should set exit code #2160

Closed
gitfool opened this issue Mar 7, 2020 · 2 comments · Fixed by #2161
Closed

GitVersionApp should set exit code #2160

gitfool opened this issue Mar 7, 2020 · 2 comments · Fixed by #2161

Comments

@gitfool
Copy link
Contributor

gitfool commented Mar 7, 2020

Since switching GitVersion to use generic hosting (17bfb2e), GitVersion stopped returning an exit code. This leads to ugliness with tools like Cake that try to parse the non-existent json output.
@arturcic
Copy link
Member

arturcic commented Mar 7, 2020

@gitfool do you have a fix for this?

@gitfool gitfool mentioned this issue Mar 7, 2020
Merged
@gitfool
Copy link
Contributor Author

gitfool commented Mar 7, 2020

@arturcic I think so. Not completely sure, but then I can't see any other way to set the exit code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH2160: Set application exit code
2 participants
@gitfool @arturcic