-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC tags trigger incorrect increments. #2329
Comments
I would love to snap my fingers and have this problem fixed, but it doesn't affect me and I have more than enough other things to do, so I neither have the incentive nor time to fix this. If you are able to invest time into figuring why this is occurring and fixing it, I would be very greatful and would of course review and merge your PR. |
You may be affected by #3041. Please have a look and let me know. |
May I ask you to provide an integration test please (or at least steps to reproduce)? I have no clue what you are expecting and I have no idea if this issue is already solved. I can tell you it is really hard to get into such issues and answer the question: Has it already been solved or not with the actual refactoring initiative!? Please provide integration tests any time. It makes life easier for the people who wants to make GitVersion stable. Thank you very much. BTW the web link in the description is broken. Cheers |
Unfortunately I'm unable to help out there. The issues was raised nearly 3 years ago and the link was to a CI run which I was unaware would expire at that time. As I recall the library was resetting the increment. E.g generating |
Okay no problem. Because of missing steps to reproduce I'm going to close this issue. |
Describe the bug
Following an RC release tag version, e.g.
v1.0.0-rc.2
incremented prerelease values are reset and appear to be based upon only the commit count since the release. This breaks the upgrade path for users.I've looked at #1600 which appears to be related but only contains tests without fixes. #1844 may be related but was closed as stale.
Expected Behavior
I would expect the version to take into consideration the new RC tag and not reset.
Actual Behavior
Calculated increments are reset which leads to version numbers that are lower than previous builds.
Possible Fix
Steps to Reproduce
Using the following GitVersion.yml
An example of such appears at the following Github Action
Context
It's rendered my nightly builds effectively useless for consumers.
Your Environment
The text was updated successfully, but these errors were encountered: