Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] use conventionalcommits.org message information by default #2395

Closed
PixnBits opened this issue Aug 27, 2020 · 3 comments · Fixed by #2553
Closed

[Feature] use conventionalcommits.org message information by default #2395

PixnBits opened this issue Aug 27, 2020 · 3 comments · Fixed by #2553

Comments

@PixnBits
Copy link

Is your feature request related to a problem? Please describe.
Simplify configuration set up by asking if conventional commits are used. Perhaps this could even be auto-detected.

Detailed Description

https://www.conventionalcommits.org/en/v1.0.0/ describes structured commit messages, which can provide information on how to increment versions. This could be manually configured via minor-version-bump-message et. al. but their default values could be changed. Before a breaking version of GitVersion, this could be a question in the configuration setup.

Context

Conventional commit messages have become more common, culminating in a specific format. By detecting or defaulting to this syntax GitVersion can work "out of the box" with projects following this trend.

Possible Implementation

Full disclosure I haven't written C# in years, but conventional-commits-parser has a JavaScript implementation of parsing commits that might be useful for the auto-detection.

@asbjornu
Copy link
Member

I agree that Conventional Commits has become so common that it would be good for GitVersion to support them out of the box. I don't use Conventional Commits myself, though, so I don't have much incentive to add this to GitVersion myself. If someone provides a PR with tests for this, I would be happy to merge, though.

@stale
Copy link

stale bot commented Nov 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 26, 2020
@stale stale bot closed this as completed Dec 26, 2020
@asbjornu
Copy link
Member

asbjornu commented Feb 1, 2021

Implemented in #2553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants