Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Support version conversion on worker service project #2629

Closed
TomGiz opened this issue Mar 24, 2021 · 3 comments · Fixed by #2630
Closed

[Bug] Support version conversion on worker service project #2629

TomGiz opened this issue Mar 24, 2021 · 3 comments · Fixed by #2630
Milestone

Comments

@TomGiz
Copy link

TomGiz commented Mar 24, 2021

Describe the bug
The Execute GitVersion Task on our Azure DevOps build pipeline is defined as follows:

  - task: gitversion/execute@0
    displayName: "GitVersion Execute (sdk style projects)"
    inputs:
      additionalArguments: '/updateprojectfiles'

One of the projects is a .NET 5 worker service. When the build pipeline executes the Execute GitVersion Task, we receive the following warning :

WARN [03/24/21 13:59:30:77] Specified project file Sdk (Microsoft.NET.Sdk.Worker) is not supported, please ensure the project sdk is of the following: Microsoft.NET.Sdk|Microsoft.NET.Sdk.Web.

Expected Behavior

A .NET 5 worker service should be supported. The DLL's file version property should be set by GitVersion.

Actual Behavior

The above warning is output.
The DLL's file version property is not set by GitVersion.

Possible Fix

Allow Microsoft.NET.Sdk.Worker.

Steps to Reproduce

Context

For the time being: low impact.
DLL has a default file version set (1.0.0.0).
The Execute GitVersion Task only logs a warning and continues without error.

Your Environment

Azure DevOps YAML pipeline.

@TomGiz TomGiz added the bug label Mar 24, 2021
@arturcic
Copy link
Member

Do you mind filling in a PR? You can have a look here

var supportedSdks = new[] { "Microsoft.NET.Sdk", "Microsoft.NET.Sdk.Web", "Microsoft.NET.Sdk.WindowsDesktop", "Microsoft.NET.Sdk.Razor" };
, you should also add a test here

@TomGiz
Copy link
Author

TomGiz commented Mar 24, 2021

Yes, I already found the culprit line of code :-) but I was indeed looking for a test in which to reproduce the problem. Thanks!
PR coming up.

@TomGiz TomGiz changed the title [Bug] [Bug] Support version conversion on worker service project Mar 24, 2021
@arturcic arturcic added improvement and removed bug labels Mar 25, 2021
@arturcic arturcic added this to the 5.6.7 milestone Mar 25, 2021
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.6.7 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants