Make tests more robust; fix windows tests (#450)

Author: Byron

Diff for: git-repository/src/config/snapshot/credential_helpers.rs

@@ -17,7 +17,7 @@ mod error {
         },
     }
 }
-use crate::bstr::ByteVec;
+use crate::bstr::{ByteSlice, ByteVec};
 pub use error::Error;
 
 impl Snapshot<'_> {
@@ -45,14 +45,17 @@ impl Snapshot<'_> {
                 match section.header().subsection_name() {
                     Some(_) => {}
                     None => {
-                        for value in section.values("helper") {
+                        for value in section.values("helper").into_iter().filter(|v| !v.trim().is_empty()) {
                             programs.push(git_credentials::Program::from_custom_definition(value.into_owned()));
                         }
                         if let Some(Some(user)) = (!url_had_user_initially).then(|| {
-                            section.value("username").and_then(|n| {
-                                let n: Vec<_> = Cow::into_owned(n).into();
-                                n.into_string().ok()
-                            })
+                            section
+                                .value("username")
+                                .filter(|n| !n.trim().is_empty())
+                                .and_then(|n| {
+                                    let n: Vec<_> = Cow::into_owned(n).into();
+                                    n.into_string().ok()
+                                })
                         }) {
                             url.set_user(Some(user));
                         }

Diff for: git-repository/tests/fixtures/make_remote_repos.sh

@@ -199,8 +199,8 @@ git clone --shared base credential-helpers
       } >> baseline.git
     }
 
-    git config credential.helper ''
-    git config credential.helper global
+    git config credential.helper ""
+    git config --add credential.helper global
     git config credential.https://example.com:8080.helper example-with-port
     git config credential.https://example.com:8080/path.helper example-with-port-and-path
     git config credential.https://example.com:8080/path.usehttppath 1

Diff for: tests/tools/src/lib.rs

@@ -317,6 +317,9 @@ fn scripted_fixture_repo_read_only_with_args_inner(
                     .stderr(std::process::Stdio::piped())
                     .current_dir(&script_result_directory)
                     .env_remove("GIT_DIR")
+                    .env_remove("GIT_ASKPASS")
+                    .env_remove("SSH_ASKPASS")
+                    .env("GIT_TERMINAL_PROMPT", "false")
                     .env("GIT_AUTHOR_DATE", "2000-01-01 00:00:00 +0000")
                     .env("GIT_AUTHOR_EMAIL", "author@example.com")
                     .env("GIT_AUTHOR_NAME", "author")