thanks clippy

Author: Byron

gix-config/src/parse/section/header.rs

@@ -59,24 +59,6 @@ fn validated_name(name: Cow<'_, BStr>) -> Result<Cow<'_, BStr>, Error> {
         .ok_or(Error::InvalidName)
 }
 
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn empty_header_names_are_legal() {
-        assert!(Header::new("", None).is_ok(), "yes, git allows this, so do we");
-    }
-
-    #[test]
-    fn empty_header_sub_names_are_legal() {
-        assert!(
-            Header::new("remote", Some(Cow::Borrowed("".into()))).is_ok(),
-            "yes, git allows this, so do we"
-        );
-    }
-}
-
 impl Header<'_> {
     ///Return true if this is a header like `[legacy.subsection]`, or false otherwise.
     pub fn is_legacy(&self) -> bool {
@@ -178,3 +160,21 @@ impl<'a> From<Header<'a>> for Event<'a> {
         Event::SectionHeader(header)
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn empty_header_names_are_legal() {
+        assert!(Header::new("", None).is_ok(), "yes, git allows this, so do we");
+    }
+
+    #[test]
+    fn empty_header_sub_names_are_legal() {
+        assert!(
+            Header::new("remote", Some(Cow::Borrowed("".into()))).is_ok(),
+            "yes, git allows this, so do we"
+        );
+    }
+}

gix-odb/tests/odb/mod.rs

@@ -1,6 +1,5 @@
 use gix_hash::ObjectId;
 use gix_testtools::fixture_path_standalone;
-pub use gix_testtools::{fixture_path, scripted_fixture_read_only};
 
 pub fn hex_to_id(hex: &str) -> ObjectId {
     ObjectId::from_hex(hex.as_bytes()).expect("40 bytes hex")

gix-packetline/src/read/sidebands/async_io.rs

@@ -72,24 +72,6 @@ enum State<'a, T> {
 #[allow(unsafe_code, clippy::non_send_fields_in_send_ty)]
 unsafe impl<'a, T> Send for State<'a, T> where T: Send {}
 
-#[cfg(test)]
-mod tests {
-    use super::*;
-    fn receiver<T: Send>(_i: T) {}
-
-    /// We want to declare items containing pointers of `StreamingPeekableIter` `Send` as well, so it must be `Send` itself.
-    #[test]
-    fn streaming_peekable_iter_is_send() {
-        receiver(StreamingPeekableIter::new(Vec::<u8>::new(), &[], false));
-    }
-
-    #[test]
-    fn state_is_send() {
-        let mut s = StreamingPeekableIter::new(Vec::<u8>::new(), &[], false);
-        receiver(State::Idle { parent: Some(&mut s) });
-    }
-}
-
 impl<'a, T, F> WithSidebands<'a, T, F>
 where
     T: AsyncRead + Unpin,
@@ -381,3 +363,21 @@ where
         Poll::Ready(Ok(nread))
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    fn receiver<T: Send>(_i: T) {}
+
+    /// We want to declare items containing pointers of `StreamingPeekableIter` `Send` as well, so it must be `Send` itself.
+    #[test]
+    fn streaming_peekable_iter_is_send() {
+        receiver(StreamingPeekableIter::new(Vec::<u8>::new(), &[], false));
+    }
+
+    #[test]
+    fn state_is_send() {
+        let mut s = StreamingPeekableIter::new(Vec::<u8>::new(), &[], false);
+        receiver(State::Idle { parent: Some(&mut s) });
+    }
+}

gix-protocol/tests/fetch/response.rs

@@ -317,7 +317,8 @@ mod v2 {
             assert_eq!(bytes_read, 1643, "should be able to read the whole pack");
             assert_eq!(&buf[..4], b"PACK");
             assert_eq!(
-                gix_hash::ObjectId::from(&buf[buf.len() - gix_hash::Kind::Sha1.len_in_bytes()..]).to_string(),
+                gix_hash::ObjectId::from_bytes_or_panic(&buf[buf.len() - gix_hash::Kind::Sha1.len_in_bytes()..])
+                    .to_string(),
                 "f34c9be7e0c3ef2c3ed7c62cc7791dbf6dc5ec9a"
             );
             Ok(())

gix-ref/src/store/file/find.rs

@@ -45,7 +45,7 @@ impl file::Store {
         Error: From<E>,
     {
         self.find_one_with_verified_input(partial.try_into()?, None)
-            .map(|r| r.map(|r| r.try_into().expect("only loose refs are found without pack")))
+            .map(|r| r.map(Into::into))
     }
 
     /// Similar to [`file::Store::find()`], but allows to pass a snapshotted packed buffer instead.
@@ -267,8 +267,7 @@ pub mod existing {
             Name: TryInto<&'a PartialNameRef, Error = E>,
             crate::name::Error: From<E>,
         {
-            self.find_existing_inner(partial, None)
-                .map(|r| r.try_into().expect("always loose without packed"))
+            self.find_existing_inner(partial, None).map(Into::into)
         }
 
         /// Similar to [`file::Store::find()`] but a non-existing ref is treated as error.

gix/src/remote/connection/fetch/update_refs/tests.rs

@@ -605,7 +605,7 @@ mod update {
         let (mut mappings, specs) = mapping_from_spec("refs/heads/symbolic:refs/remotes/origin/new", &repo);
         mappings.push(Mapping {
             remote: Source::Ref(gix_protocol::handshake::Ref::Direct {
-                full_ref_name: "refs/heads/main".try_into().unwrap(),
+                full_ref_name: "refs/heads/main".into(),
                 object: hex_to_id("f99771fe6a1b535783af3163eba95a927aae21d5"),
             }),
             local: Some("refs/heads/symbolic".into()),
@@ -728,7 +728,7 @@ mod update {
         let (mut mappings, specs) = mapping_from_spec("HEAD:refs/remotes/origin/new-HEAD", &repo);
         mappings.push(Mapping {
             remote: Source::Ref(gix_protocol::handshake::Ref::Direct {
-                full_ref_name: "refs/heads/main".try_into().unwrap(),
+                full_ref_name: "refs/heads/main".into(),
                 object: hex_to_id("f99771fe6a1b535783af3163eba95a927aae21d5"),
             }),
             local: Some("refs/remotes/origin/main".into()),

gix/src/remote/url/scheme_permission.rs

@@ -72,7 +72,7 @@ impl SchemePermission {
                         scheme
                             .to_str()
                             .ok()
-                            .and_then(|scheme| gix_url::Scheme::try_from(scheme).ok().map(|scheme| (section, scheme)))
+                            .map(|scheme| (section, gix_url::Scheme::from(scheme)))
                     })
                 }) {
                     if let Some(value) = section