feat!: respect core.useReplaceRefs and remove gitoxide.objects.noReplace.

The gitoxide specific variable wasn't needed in the first place.

Author: Byron

gix/src/config/cache/init.rs

@@ -426,10 +426,6 @@ fn apply_environment_overrides(
             Some(Cow::Borrowed("objects".into())),
             objects,
             &[
-                {
-                    let key = &gitoxide::Objects::NO_REPLACE;
-                    (env(key), key.name)
-                },
                 {
                     let key = &gitoxide::Objects::REPLACE_REF_BASE;
                     (env(key), key.name)
@@ -491,6 +487,10 @@ fn apply_environment_overrides(
                 let key = &Core::SSH_COMMAND;
                 (env(key), key.name, git_prefix)
             },
+            {
+                let key = &Core::USE_REPLACE_REFS;
+                (env(key), key.name, objects)
+            },
         ] {
             if let Some(value) = var_as_bstring(var, permission) {
                 section.push_with_comment(

gix/src/config/tree/sections/core.rs

@@ -63,6 +63,9 @@ impl Core {
     /// The `core.sshCommand` key.
     pub const SSH_COMMAND: keys::Executable = keys::Executable::new_executable("sshCommand", &config::Tree::CORE)
         .with_environment_override("GIT_SSH_COMMAND");
+    /// The `core.useReplaceRefs` key.
+    pub const USE_REPLACE_REFS: keys::Boolean = keys::Boolean::new_boolean("useReplaceRefs", &config::Tree::CORE)
+        .with_environment_override("GIT_NO_REPLACE_OBJECTS");
 }
 
 impl Section for Core {
@@ -92,6 +95,7 @@ impl Section for Core {
             &Self::EXCLUDES_FILE,
             &Self::ATTRIBUTES_FILE,
             &Self::SSH_COMMAND,
+            &Self::USE_REPLACE_REFS,
         ]
     }
 }

gix/src/config/tree/sections/gitoxide.rs

@@ -317,8 +317,7 @@ mod subsections {
                 .with_note("If unset or 0, there is no object cache")
                 .with_environment_override("GITOXIDE_OBJECT_CACHE_MEMORY");
         /// The `gitoxide.objects.noReplace` key.
-        pub const NO_REPLACE: keys::Boolean = keys::Boolean::new_boolean("noReplace", &Gitoxide::OBJECTS)
-            .with_environment_override("GIT_NO_REPLACE_OBJECTS");
+        pub const NO_REPLACE: keys::Boolean = keys::Boolean::new_boolean("noReplace", &Gitoxide::OBJECTS);
         /// The `gitoxide.objects.replaceRefBase` key.
         pub const REPLACE_REF_BASE: keys::Any =
             keys::Any::new("replaceRefBase", &Gitoxide::OBJECTS).with_environment_override("GIT_REPLACE_REF_BASE");
@@ -330,7 +329,7 @@ mod subsections {
         }
 
         fn keys(&self) -> &[&dyn Key] {
-            &[&Self::CACHE_LIMIT, &Self::NO_REPLACE, &Self::REPLACE_REF_BASE]
+            &[&Self::CACHE_LIMIT, &Self::REPLACE_REF_BASE]
         }
 
         fn parent(&self) -> Option<&dyn Section> {

gix/src/open/repository.rs

@@ -284,12 +284,12 @@ fn replacement_objects_refs_prefix(
     mut filter_config_section: fn(&gix_config::file::Metadata) -> bool,
 ) -> Result<Option<PathBuf>, Error> {
     let is_disabled = config
-        .boolean_filter_by_key("gitoxide.objects.noReplace", &mut filter_config_section)
-        .map(|b| gitoxide::Objects::NO_REPLACE.enrich_error(b))
+        .boolean_filter_by_key("core.useReplaceRefs", &mut filter_config_section)
+        .map(|b| Core::USE_REPLACE_REFS.enrich_error(b))
         .transpose()
         .with_leniency(lenient)
         .map_err(config::Error::ConfigBoolean)?
-        .unwrap_or_default();
+        .unwrap_or(true);
 
     if is_disabled {
         return Ok(None);

gix/tests/repository/open.rs

@@ -394,7 +394,7 @@ mod with_overrides {
         for (key, expected) in [
             ("gitoxide.http.verbose", "true"),
             ("gitoxide.allow.protocolFromUser", "file-allowed"),
-            ("gitoxide.objects.noReplace", "no-replace"),
+            ("core.useReplaceRefs", "no-replace"),
             ("gitoxide.objects.replaceRefBase", "refs/replace-mine"),
             ("gitoxide.committer.nameFallback", "committer name"),
             ("gitoxide.committer.emailFallback", "committer email"),