Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tokio feature #1565

Open
Austaras opened this issue Aug 28, 2024 · 2 comments
Open

Add a tokio feature #1565

Austaras opened this issue Aug 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Austaras
Copy link

Summary 💡

Title.

Motivation 🔦

It won't make any difference to end user, but when consumed as a rust lib, it would be great if one can use gitoxide with the more popular async runtime.

@Austaras Austaras added the enhancement New feature or request label Aug 28, 2024
@NobodyXu
Copy link
Contributor

Actually the blocking-reqwest feature uses reqwest which uses tokio.

And it also has an async network client feature that exposes the async API, but then there's no convenient high-level method like synchronous code have.

The underlying crate supports async/sync.

@Byron
Copy link
Member

Byron commented Aug 28, 2024

The way I understand this issue is such that wherever currently async-std is used, there should be an alternative that uses the respective tokio type. This way, those who have tokio running already can just use that, without the need to link to another runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants