-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gix 0.43 cannot be build after 0.44 was published #834
Comments
Thanks for reporting! Could you verify it's working now? |
Nevermind :/ - I brought v7.4 back as yanking it would break The issue really is that I can't release a patch for
All versions of |
Yanking of old versions of gix broke my CI pipelines. I'm using vergen with gitoxide to generate version information. In my
Here is the pipeline in question: https://github.com/vbrandl/petnames-generator/actions/runs/4818190404/jobs/8579842209?pr=114 How could this be fixed? |
It seems that yanking all versions that would be broken now will only be suitable for crates that have Cargo.lock files checked in. Without it, dependency resolution of the Cargo.toml file fails, and I can only advocate for doing this in future to not be vulnerable to dependency hickups like these. For you it would be too late though as there is no way to generate the I created a PR for I will also see how I can fix this issue without yanking everything, just needs a little longer. After all, who breaks the world has to fix it ;) (Galgenhumor). |
I created the same PR rustyhorde/vergen#196 |
Closing as the underlying problem should be fixed now. For posterity, here is how that was done:
As I don't think this will never happen again, unfortunately, as it's down to human error here and nothing that can be done about it, I hope I will be able to remember what I came up with to be able to fix issues like these properly in future. It's simply not possible anymore not fix all crates depending on My apologies for the inconvenience. There have been some discussions going on among high-profile members of the Rust community about using |
@Byron
|
This confused me as well, and even though it upgrades to When this happens, a workaround is an installation with Fun fact: Dealing with the fallout cost me 90 minutes at least, and it's hard to count how much time was lost indirectly by those affected by it. With that on the side of value lost, the cause of it is literally the lack of a single character: |
Thanks - gitoxide v0.25.0 installed perfectly. |
Great. The problem seems fixed |
Duplicates
Current behavior 😯
See apache/datafusion#6132 . gix 0.43 seems to fail to build:
Also see substrait-io/substrait-rs#97 .
Expected behavior 🤔
0.43 still builds
Steps to reproduce 🕹
2feae85523dde923599dae32bfa383774f380f74
git submodule update --init --recursive
(build script needs submodules)Cargo.lock
file below (since substrait is a lib and hence doesn't commitCargo.lock
)cargo check
Cargo.lock:
The text was updated successfully, but these errors were encountered: