Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors delegating to Traces #2556

Open
Danibelle opened this issue Oct 3, 2021 · 7 comments
Open

Errors delegating to Traces #2556

Danibelle opened this issue Oct 3, 2021 · 7 comments
Assignees
Labels
bug Issues that arise due to code architecture

Comments

@Danibelle
Copy link
Collaborator

@Danibelle
Copy link
Collaborator Author

Popups are stacked on top of the Delegation window, which I then have to close. I don't know if I really got an error, the transaction really went through, if I should just close out the Delegation window or do it again:

image

image

image

@Danibelle
Copy link
Collaborator Author

Sometimes there is a "Transaction Failed" in the stack of errors.. then after I close them all out I get a "Transaction Successful!"

image

@MoeNick MoeNick added the bug Issues that arise due to code architecture label Oct 3, 2021
@MoeNick
Copy link
Member

MoeNick commented Oct 3, 2021

@RamRamez cam you please investigate?

@aminlatifi
Copy link
Member

aminlatifi commented Oct 3, 2021

This issue is somehow complicated. Basically DApp prepares transactions (here delegation) based on pledges data stored in backend. On @Danibelle first delegation, she couldn't send updated data to feathers so the pledges data were obsolete.
So next delegation attempt was created based on that obsolete data, that's the reason the smart contract rejected the call since probably the intended pledges had not enough money inside to pay.

No easy fix comes to my mind at this moment, the only working solution I would recommend is that after delegating on project money (Here the campaign), user should wait for about 10 blocks of rinkeby to be mined before next attempt to delegating from the same project.

@Danibelle
Copy link
Collaborator Author

OK Thank you Amin.

I understand this from subsequent delegations - the difference between the first delegation (yours) and subsequent delegations is that there were TWO "Oh No" messages instead of just one.

But the bigger issue is that instantly upon signing the MetaMask transaction - all the errors popped up instantly.
An "Oh No"..
With a "Transaction Failed" beneath it..
and the Delegation window remained open below it.

Seems like there should be a delay after signing that says WAIT ... and the Delegation Window should either close when I select Delegate, or stay in a waiting stage until the blocks are mined.

@Danibelle
Copy link
Collaborator Author

I do get a 'Transaction Successful' once the blocks are mined.

@aminlatifi
Copy link
Member

In DM also @Danibelle mentioned an important clue! The first delegation was not complete!
To explain more, a trace needed 1.39 ETH but at the first delegation 1.2 ETH was delegated. So my assumption about obsolete state can not be the reason in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that arise due to code architecture
Projects
None yet
Development

No branches or pull requests

4 participants