Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellar | check to show GIVback components, if users is not eligible. #4659

Closed
MoeNick opened this issue Sep 1, 2024 · 4 comments
Closed
Assignees
Labels

Comments

@MoeNick
Copy link
Member

MoeNick commented Sep 1, 2024

          Also! If I'm not signed in and make a successful donation I shouldn't see the GIVbacks component on the donation success page, since I won't actually get GIVbacks 

Image

Originally posted by @divine-comedian in #4582 (comment)

@MoeNick
Copy link
Member Author

MoeNick commented Sep 1, 2024

Based on the above report @Meriem-B

We should check the users eligibility with these conditions:

  1. Project is verified
  2. Token is GIVback eligible
  3. User is signed in

Those conditions would be effective on

  1. GIVback icon on token logo
  2. The toast message on reminding to sign in
  3. the GIVback components on success page.

FYI: @maryjaf

@MoeNick MoeNick added the Stellar label Sep 1, 2024
@Meriem-BM Meriem-BM moved this from New Issues to Code Review/PR in All-Devs Sep 2, 2024
@Meriem-BM Meriem-BM moved this from Code Review/PR to QA in All-Devs Sep 2, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Sep 2, 2024

  • GIVback icon on token logo

So when my user isn't signed in, the GIVback eligible icon shouldn't be shown? @MoeNick
Now in this case the givback icon is shown @Meriem-BM

Image

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 2, 2024

The showing of GIVback components on success page works as expected

Not signed user :

Image

Sign user:

Image

@MoeNick
Copy link
Member Author

MoeNick commented Sep 3, 2024

  • GIVback icon on token logo

So when my user isn't signed in, the GIVback eligible icon shouldn't be shown? @MoeNick Now in this case the givback icon is shown @Meriem-BM

Image

I think it's fine @maryjaf , user can see the icon and givback eligibility toast message. so lets put it in done

@maryjaf maryjaf moved this from QA to Done in All-Devs Sep 3, 2024
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants