-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Sitemap for Better SEO #915
Comments
This google doc for Sitemap: |
@mhmdksh @MohammadPCh - is this issue still relevant? I'm VERY interested in improving our SEO. |
@mhmdksh can you please provide an update on this issue? |
@divine-comedian Sorry I can't provide any update on this neither this is my field of expertise. I prefer if I get unassigned as this is a Frontend/SEO-Optimization issue, not Devops work. Thanks @MohammadPCh Anyone can take this?? |
@MohammadPCh can this issue be passed to someone or what is the next course of action? |
@kkatusic @lovelgeorge99 @Reshzera Hey everyone, who has the bandwidth to take this on? We need a script to:
Let me know if you need any help. |
I will take it, thx @MohammadPCh |
@divine-comedian and @MohammadPCh, cc @CarlosQ96 is it ok to expose users inside sitemap? |
I am not sure about what the implications are so I would defer to what either of them think |
Let's than wait @MohammadPCh and @CarlosQ96 response ;) |
@kkatusic Yes we can add the public profile to the sitemap. but we should disallow the dashboard and private zones. |
thx @MohammadPCh , let's hear also @CarlosQ96 response about this ;) |
Ok we should make a query just to expose the minimum required info of users. |
@kkatusic Sounds good to make the cronjob once per week. Exposing public data only. |
need to provide some back-end function for listing users, need to generate user sitemap only with public data on front-end. @kkatusic please review and add estimate of when this can be completed. |
I will try to finish this week, but have now problem with BE, we will try to fix that before because I need BE functions also to finish this one. |
@CarlosQ96 can you give Giveth/impact-graph#1887 a review? once BE is merged we can do FE |
Needs PR Review by @CarlosQ96 |
Check when this job when it runs on Sunday and see if it needs to be optimized. Need to see results of the job and see if it generates as it should on FE side, should be https://staging.giveth.io/sitemap.xml need to have all data about projects users rounds inside of sitemap. Attach XML file to google search console once it is generated. AC
|
@divine-comedian, cc @CarlosQ96 , files generated fine, but project contain some character and I improved function for escaping that characters, sitemap files:
|
Thanks, so what are the next steps @kkatusic - do we need to wait again until next Sunday to see the results? |
I will check again on next Monday. I generated on locahost and it's fine, but you never know what new character can appears. |
@kkatusic is on it |
@CarlosQ96 if you can verify that back-end staging errors is fixed then we can push pending PRs We are waiting to monitor other cronJobs since they seem to be causing resource issues but we're not sure which ones. |
bump on this @CarlosQ96 |
@divine-comedian, cc @CarlosQ96, FE is merged, we will check BE soon |
@CarlosQ96 @kkatusic this PR still needs a merge |
need to resolve Giveth/impact-graph#1922 before we can safely merge the related PR |
@kkatusic will try to run this job tomorrow and make sure results are what we expect |
@divine-comedian again I stuck with this, after update on BE side it was resolving wrong IP address, for some reason hosts file has been set up for looking same FE url on same server, Moe helped and removed that after he found problem. |
We need to generate a sitemap for our website to search engines can find our pages better and easier. now they can only crawl pages linked to our popular pages (homepage or first load of projects).
I suggest creating the sitemap once per day. We need the devOps team's help with this.
@aminlatifi @MoeNick
The text was updated successfully, but these errors were encountered: