Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sitemap for Better SEO #915

Open
MohammadPCh opened this issue Jun 12, 2022 · 32 comments
Open

Create Sitemap for Better SEO #915

MohammadPCh opened this issue Jun 12, 2022 · 32 comments
Assignees

Comments

@MohammadPCh
Copy link
Collaborator

We need to generate a sitemap for our website to search engines can find our pages better and easier. now they can only crawl pages linked to our popular pages (homepage or first load of projects).
I suggest creating the sitemap once per day. We need the devOps team's help with this.
@aminlatifi @MoeNick

@MohammadPCh
Copy link
Collaborator Author

@divine-comedian
Copy link
Contributor

@mhmdksh @MohammadPCh - is this issue still relevant?

I'm VERY interested in improving our SEO.

@divine-comedian
Copy link
Contributor

@mhmdksh can you please provide an update on this issue?

@mhmdksh
Copy link
Collaborator

mhmdksh commented Jun 25, 2024

@mhmdksh can you please provide an update on this issue?

@divine-comedian Sorry I can't provide any update on this neither this is my field of expertise. I prefer if I get unassigned as this is a Frontend/SEO-Optimization issue, not Devops work.

Thanks

@MohammadPCh Anyone can take this??

@divine-comedian divine-comedian added P2 A normal to do item or feature. and removed devops labels Jun 25, 2024
@divine-comedian divine-comedian moved this to Done in All-Devs Jun 26, 2024
@divine-comedian divine-comedian moved this from Done to Product Backlog in All-Devs Jun 26, 2024
@divine-comedian
Copy link
Contributor

@MohammadPCh can this issue be passed to someone or what is the next course of action?

@MohammadPCh
Copy link
Collaborator Author

MohammadPCh commented Aug 5, 2024

@kkatusic @lovelgeorge99 @Reshzera Hey everyone, who has the bandwidth to take this on?

We need a script to:

  1. Retrieve projects, users, and campaigns from the server
  2. Add the static pages
  3. Create a sitemap

Let me know if you need any help.

@kkatusic
Copy link
Collaborator

kkatusic commented Aug 5, 2024

@kkatusic @lovelgeorge99 @Reshzera Hey everyone, who has the bandwidth to take this on?

We need a script to:

  1. Retrieve projects, users, and campaigns from the server
  2. Add the static pages
  3. Create a sitemap

Let me know if you need any help.

I will take it, thx @MohammadPCh

@kkatusic kkatusic assigned kkatusic and unassigned MohammadPCh Aug 5, 2024
@divine-comedian divine-comedian moved this from Product Backlog to In Progress in All-Devs Aug 9, 2024
@kkatusic
Copy link
Collaborator

kkatusic commented Nov 4, 2024

@divine-comedian and @MohammadPCh, cc @CarlosQ96 is it ok to expose users inside sitemap?

@divine-comedian
Copy link
Contributor

I am not sure about what the implications are so I would defer to what either of them think

@kkatusic
Copy link
Collaborator

kkatusic commented Nov 5, 2024

Let's than wait @MohammadPCh and @CarlosQ96 response ;)

@MohammadPCh
Copy link
Collaborator Author

@kkatusic Yes we can add the public profile to the sitemap. but we should disallow the dashboard and private zones.

@kkatusic
Copy link
Collaborator

kkatusic commented Nov 6, 2024

@kkatusic Yes we can add the public profile to the sitemap. but we should disallow the dashboard and private zones.

thx @MohammadPCh , let's hear also @CarlosQ96 response about this ;)

@CarlosQ96
Copy link
Collaborator

Ok we should make a query just to expose the minimum required info of users.
Also how often will the sitemap be generated? Ideally we could have a ipfs updated every day. I'm not sure a open public endpoint is that efficient even with cache. It's loading too much data into memory.

@CarlosQ96
Copy link
Collaborator

@kkatusic Sounds good to make the cronjob once per week. Exposing public data only.

@divine-comedian
Copy link
Contributor

need to provide some back-end function for listing users, need to generate user sitemap only with public data on front-end.

@kkatusic please review and add estimate of when this can be completed.

@divine-comedian divine-comedian removed the P2 A normal to do item or feature. label Nov 28, 2024
@kkatusic
Copy link
Collaborator

kkatusic commented Dec 2, 2024

need to provide some back-end function for listing users, need to generate user sitemap only with public data on front-end.

@kkatusic please review and add estimate of when this can be completed.

I will try to finish this week, but have now problem with BE, we will try to fix that before because I need BE functions also to finish this one.

@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Dec 5, 2024
@divine-comedian
Copy link
Contributor

divine-comedian commented Dec 9, 2024

@CarlosQ96 can you give Giveth/impact-graph#1887 a review?

once BE is merged we can do FE

@divine-comedian
Copy link
Contributor

Needs PR Review by @CarlosQ96

@divine-comedian
Copy link
Contributor

Check when this job when it runs on Sunday and see if it needs to be optimized.

Need to see results of the job and see if it generates as it should on FE side, should be https://staging.giveth.io/sitemap.xml

need to have all data about projects users rounds inside of sitemap. Attach XML file to google search console once it is generated.

AC

  • generates xml file with correct data
  • should not make too many requests to the back-end

@kkatusic
Copy link
Collaborator

kkatusic commented Jan 6, 2025

@divine-comedian, cc @CarlosQ96 , files generated fine, but project contain some character and I improved function for escaping that characters, sitemap files:

@divine-comedian
Copy link
Contributor

Thanks, so what are the next steps @kkatusic - do we need to wait again until next Sunday to see the results?

@kkatusic
Copy link
Collaborator

kkatusic commented Jan 7, 2025

Thanks, so what are the next steps @kkatusic - do we need to wait again until next Sunday to see the results?

I will check again on next Monday. I generated on locahost and it's fine, but you never know what new character can appears.

@MoeNick
Copy link
Member

MoeNick commented Jan 13, 2025

@kkatusic is on it

@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 23, 2025

@CarlosQ96 if you can verify that back-end staging errors is fixed then we can push pending PRs

We are waiting to monitor other cronJobs since they seem to be causing resource issues but we're not sure which ones.

@divine-comedian
Copy link
Contributor

bump on this @CarlosQ96

@kkatusic
Copy link
Collaborator

@divine-comedian, cc @CarlosQ96, FE is merged, we will check BE soon

@divine-comedian
Copy link
Contributor

@CarlosQ96 @kkatusic this PR still needs a merge

@divine-comedian
Copy link
Contributor

need to resolve Giveth/impact-graph#1922 before we can safely merge the related PR

@divine-comedian divine-comedian moved this from Code Review/PR to Product Backlog in All-Devs Feb 10, 2025
@kkatusic kkatusic moved this from Product Backlog to In Progress in All-Devs Feb 18, 2025
@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Feb 18, 2025
@divine-comedian
Copy link
Contributor

@kkatusic will try to run this job tomorrow and make sure results are what we expect

@divine-comedian divine-comedian moved this from Code Review/PR to QA in All-Devs Feb 18, 2025
@kkatusic kkatusic moved this from QA to In Progress in All-Devs Feb 20, 2025
@kkatusic
Copy link
Collaborator

@divine-comedian again I stuck with this, after update on BE side it was resolving wrong IP address, for some reason hosts file has been set up for looking same FE url on same server, Moe helped and removed that after he found problem.
Then new issue, Verel don't allow you to change file or add new file inside public folder or any other problem, files are only read-only state.
Then I tried to update files to Pinata and have draft working copy, by Pinata is changing every time uploaded file URL, this not acceptable for us, I think we will need to move this URL data to database, then I need more time, migration, database table, resolver, api url....

@divine-comedian divine-comedian moved this from In Progress to Sprint Backlog in All-Devs Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint Backlog
Development

No branches or pull requests

6 participants