Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Message entity revisionable #5

Closed
mccrodp opened this issue Jan 4, 2015 · 2 comments
Closed

Make Message entity revisionable #5

mccrodp opened this issue Jan 4, 2015 · 2 comments

Comments

@mccrodp
Copy link
Contributor

mccrodp commented Jan 4, 2015

It looks like Message entity does not provide revisions.

Would this affect many areas of the code if we follow the documentation to make an entity revisionable?

Is this something that can make it into Message on D7, through a contributed patch or otherwise, or will it make it into D8 only now?

@amitaibu
Copy link
Member

amitaibu commented Jan 5, 2015

I can't think of a real use case where Message would need to be revisionable. Anyway, this can probably be done in contrib.

@amitaibu amitaibu closed this as completed Jan 5, 2015
@mccrodp
Copy link
Contributor Author

mccrodp commented Jan 5, 2015

Thanks, this makes sense as contrib if it could be done there, using hook_entity_info_alter and whatever else is needed.

The use case came about on a Message Private issue as a work around providing accessible timestamps on field instances, i.e. - a field added per message revision where the message entity is a message thread.

I don't know how valid that method is and I decided against it anyway, but revisionable Messages could be used in Message Private in future, so it's good to know it may be possible in contrib as "Message Revisions" or similar. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants