Upgrade PhantomJS to 2.x on Travis #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jhedstrom
commented
Nov 10, 2016
jhedstrom
commented
- Fixes Get JS tests running on Travis #60
jhedstrom
force-pushed
the
60-travis-phantomjs
branch
12 times, most recently
from
85b7a36
to
729fb8d
Compare
|
You can cache the PhantomJS binary. Have a look at https://github.com/jibran/dynamic_entity_reference/blob/8.x-1.x/.travis.yml |
jhedstrom
force-pushed
the
60-travis-phantomjs
branch
5 times, most recently
from
13467e1
to
2fed93c
Compare
jhedstrom
force-pushed
the
60-travis-phantomjs
branch
from
2fed93c
to
a8eb4bb
Compare
|
Thanks @jibran. I've added the caching bit, but JavascriptTestBase tests still fail (are skipped) with an empty exception. Have you successfully ran these on travis? I have debugging turned on for the phantomjs command, so the output there is a bit messy. There are several 500 errors that look suspicious... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.