Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Remove the match_limit schema when dropping support for 8.7.x #581

Closed
claudiu-cristea opened this issue Dec 8, 2019 · 4 comments · Fixed by #721
Closed

Remove the match_limit schema when dropping support for 8.7.x #581

claudiu-cristea opened this issue Dec 8, 2019 · 4 comments · Fixed by #721
Assignees

Comments

@claudiu-cristea
Copy link
Collaborator

Remove the match_limit schema from field.widget.settings.og_complex when dropping support for Drupal 8.7.x.

@damienmckenna
Copy link
Contributor

Won't this be solved when #160 is committed? Should we focus our attention there instead?

@MPParsley
Copy link
Collaborator

Won't this be solved when #160 is committed? Should we focus our attention there instead?

@damienmckenna, I agree that 160 will be an important step forward for this project but the current PR's that try to solve that are in (very) a bad shape.

Have a look at #570 (review) I moved over the initial branch from amitaibu:160-remove-complex-widget to this repository so we can work on it more easily. I noticed you created a merge branch for different PR's, any chance you could have the work spent there flow back to #570?

@damienmckenna
Copy link
Contributor

@MPParsley,
The PR I created (#571) was a stopgap I needed for a project to combine the three PRs so it could be added to a composer workflow.
I'll try to make time to work on #570 and the others to get them into a finished state that could be committed.

@claudiu-cristea
Copy link
Collaborator Author

claudiu-cristea commented Dec 9, 2019

Won't this be solved when #160 is committed? Should we focus our attention there instead?

I have no idea. But if it does, it's still a question if it will be merged in time. That means before the support for Drupal 8.7.x is dropped. Then we can "won't fix" this. Otherwise this will get a simple cleanup PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants