You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Raster.interp_points function has several urgent issues:
The mode argument is never used, and actually defines the wrong thing (it is the order argument that defines the type of interpolation in map_coordinates, mode is for behaviour around the margin of the image),
The
Raster.interp_points
function has several urgent issues:mode
argument is never used, and actually defines the wrong thing (it is theorder
argument that defines the type of interpolation inmap_coordinates
,mode
is for behaviour around the margin of the image),prefilter
argument ofmap_coordinates
runs by default: https://docs.scipy.org/doc/scipy/reference/generated/scipy.ndimage.map_coordinates.html#scipy-ndimage-map-coordinates. This spline pre-filter will actually expand NaNs for up to 20 PIXELS (tested withorder=3
on this data: https://github.com/ICESat2-SlideRule/coregistration/blob/master/xdem_test.ipynb),map_coordinates
is used for performance (much faster thaninterpn
), but only works on grids of equal spacing, need to combine withinterpn
,value_at_coords
, see Improve docstrings ofRaster.value_at_coords
andRaster.interp_points
, or merge the two methods. #395.The text was updated successfully, but these errors were encountered: