Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the 'clip' method #81

Closed
adehecq opened this issue Feb 19, 2021 · 4 comments · Fixed by #351
Closed

Implement the 'clip' method #81

adehecq opened this issue Feb 19, 2021 · 4 comments · Fixed by #351
Assignees
@adehecq
Labels
enhancement Feature improvement or request

Comments

@adehecq
Copy link
Member

adehecq commented Feb 19, 2021

Currently, the clip method is empty
@adehecq adehecq added the enhancement Feature improvement or request label Feb 19, 2021
@adehecq adehecq self-assigned this Feb 19, 2021
@atedstone
Copy link
Member

How is clipping different to cropping? (There's a crop() method)

@adehecq
Copy link
Member Author

adehecq commented Mar 1, 2021

Good question! I didn't realize the (empty) clip function was in georaster. I think it was intended for geovector.py. Clipping a set of shapes to a raster extent for example.

@atedstone
Copy link
Member

@adehecq can we close this issue?

@adehecq
Copy link
Member Author

adehecq commented Mar 19, 2021

No, still need to implement this for geovector.

@atedstone atedstone mentioned this issue Jun 11, 2021
Closed
@rhugonnet rhugonnet mentioned this issue Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adehecq adehecq

Labels
enhancement Feature improvement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write documentation and streamline general behaviour rhugonnet/geoutils
2 participants
@atedstone @adehecq