Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Nuth and Kääb 2011 implementation by stopping when error stops improving #124

Closed
erikmannerfelt opened this issue May 19, 2021 · 1 comment · Fixed by #135
Closed
Labels
enhancement Feature improvement or request performance Improvement to feature performance

Comments

@erikmannerfelt
Copy link
Contributor

Currently, there's a pretty lazy threshold system where if the NMAD drops below 0.05, it will end prematurely:

if i > 5 and nmad < self.error_threshold:

It would be much better to stop when the NMAD stops improving instead, because most of the time, the NMAD will never reach 0.05. This could be done either with a simple check "check that the NMAD was better than last time" or better, check with the last X errors "check that the NMAD improved compared to any of the last X iterations". The latter is preferable as it is less likely to stop in local minima.

@erikmannerfelt erikmannerfelt added the enhancement Feature improvement or request label May 19, 2021
@adehecq adehecq linked a pull request Jun 3, 2021 that will close this issue
@adehecq
Copy link
Member

adehecq commented Jun 3, 2021

Solved by #135

@adehecq adehecq closed this as completed Jun 3, 2021
@erikmannerfelt erikmannerfelt added the performance Improvement to feature performance label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request performance Improvement to feature performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants