Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEMs with NaNs (or synthesise them) for tests #64

Open
erikmannerfelt opened this issue Mar 21, 2021 · 2 comments
Open

Add DEMs with NaNs (or synthesise them) for tests #64

erikmannerfelt opened this issue Mar 21, 2021 · 2 comments
Assignees
Labels
priority Needs to be fixed rapidly test-suite Issue related to testing

Comments

@erikmannerfelt
Copy link
Contributor

Right now, the Longyearbyen test DEMs are void-free. Therefore, all the tests that pass are only guaranteed to pass with void-free examples. I've had large issues with the coreg functions and I think it is because of nans, so this should be added to further find out what's wrong with them.

I think this would be a good first step toward fixing #61.

@erikmannerfelt erikmannerfelt added the enhancement Feature improvement or request label Mar 21, 2021
@erikmannerfelt erikmannerfelt self-assigned this Mar 21, 2021
@adehecq
Copy link
Member

adehecq commented Mar 22, 2021

Yes, add NaNs but also masked arrays.

@erikmannerfelt
Copy link
Contributor Author

Indeed!

@erikmannerfelt erikmannerfelt added test-suite Issue related to testing and removed enhancement Feature improvement or request labels Jul 2, 2021
@rhugonnet rhugonnet added the priority Needs to be fixed rapidly label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Needs to be fixed rapidly test-suite Issue related to testing
Projects
None yet
Development

No branches or pull requests

3 participants