Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filters in a CoregPipeline #77

Closed
erikmannerfelt opened this issue Apr 8, 2021 · 1 comment
Closed

Allow filters in a CoregPipeline #77

erikmannerfelt opened this issue Apr 8, 2021 · 1 comment
Labels
enhancement Feature improvement or request

Comments

@erikmannerfelt
Copy link
Contributor

Copying the code suggested by @rhugonnet, this (or something very similar) should be possible:

step1 = filters.NMAD()
step2 = coreg.BiasCorr()
step3. = filters.MedianKernel()
step4 = coreg.ICP()
step5 = biascorr.AlongTrack()

pipeline = step1 + step2 + step3 + step4 + step5

It either suggests a more general Pipeline class, or just that the (not yet implemented) Filter class just assumes it will be used in a CoregPipeline when calling Filter.__add__()
@erikmannerfelt erikmannerfelt added the enhancement Feature improvement or request label Apr 8, 2021
@rhugonnet
Copy link
Member

rhugonnet commented Aug 1, 2023 •
edited
Loading

The new structure we discussed in #158 now allows filters! (just need to implement the filters now! 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature improvement or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhugonnet @erikmannerfelt