Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move coreg.BiasCorr and coreg.Deramp to biascorr.py? #78

Closed
erikmannerfelt opened this issue Apr 8, 2021 · 1 comment
Closed

Move coreg.BiasCorr and coreg.Deramp to biascorr.py? #78

erikmannerfelt opened this issue Apr 8, 2021 · 1 comment
Labels
enhancement Feature improvement or request

Comments

@erikmannerfelt
Copy link
Contributor

To better fit the names of the script files, these may fit better in biascorr.py.

I strongly suggest that they still inherit from the Coreg class, however, to be fully compatible with each other. I suggest the same for e.g. biascorr.AlongTrack().
@erikmannerfelt erikmannerfelt added the enhancement Feature improvement or request label Apr 8, 2021
@erikmannerfelt erikmannerfelt mentioned this issue Apr 13, 2021
Merged
@rhugonnet
Copy link
Member

Fixed by #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature improvement or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhugonnet @erikmannerfelt