Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globbing tests fail for read_json #2520

Closed
tychoish opened this issue Jan 27, 2024 · 1 comment
Closed

globbing tests fail for read_json #2520

tychoish opened this issue Jan 27, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
next

Comments

@tychoish
Copy link
Contributor

https://github.com/GlareDB/glaredb/pull/2494/files#diff-ad3e28119b8842c1a92be5827c9fb7dafe2f1f6eaf26b69a79904cf047b04e97R71

I couldn't get this test to pass locally. I think we should let #2494 land without fixing this because the bug is (presumably) already in bson, and it might only impact local cases, but I wanted to put it here to make sure someone looks at it.
@tychoish tychoish added the bug Something isn't working label Jan 27, 2024
@tychoish tychoish added this to the next milestone Jan 27, 2024
@scsmithr scsmithr changed the title globbing tests fail globbing tests fail for read_json Jan 27, 2024
@tychoish tychoish mentioned this issue Feb 12, 2024
Closed
@tychoish
Copy link
Contributor Author

tychoish commented Mar 6, 2024

#2709 resolved this issue.

@tychoish tychoish closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@tychoish