Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for liquid template engine #1416

Closed
BigWillie opened this issue Dec 17, 2016 · 5 comments
Closed

Add support for liquid template engine #1416

BigWillie opened this issue Dec 17, 2016 · 5 comments

Comments

@BigWillie
Copy link

BigWillie commented Dec 17, 2016

Please could you add support for HTML (Liquid)

"Atom Beautify could not determine a supported beautifier to handle this file with grammar "HTML (Liquid)" and extension "liquid". If you would like to request support for this file and its language, please create an issue for Atom Beautify at https://github.com/Glavin001/atom-beautify/issues"

I can sort of fudge it by setting the file type to HTML (Twig) (liquid and twig have similar syntax)

@prettydiff
Copy link
Collaborator

First, test you code in Pretty Diff at http://prettydiff.com/?m=beautify and see if it breaks your code. Twig uses Pretty Diff at the beautifier.

If all is well then I would create a pull request with a liquid.coffee file modeled after the Twig file at https://github.com/Glavin001/atom-beautify/blob/master/src/languages/twig.coffee

Once that pull request is merged in all should be well.

@prettydiff prettydiff self-assigned this Dec 19, 2016
@prettydiff
Copy link
Collaborator

This comment might also be helpful: #261 (comment)

@BigWillie
Copy link
Author

Yep - it works in prettydiff - indeed, it presumed the liquid was .twig 👍

@rickydazla
Copy link

Jekyll also uses Liquid FWIW

@Glavin001
Copy link
Owner

Closing as duplicate of #393 and reopening #393

@Glavin001 Glavin001 self-assigned this Apr 20, 2017
@Glavin001 Glavin001 added this to the v0.30.0 milestone Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants