Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP not working if filters not set #148

Closed
noah-b opened this issue Dec 3, 2014 · 3 comments
Closed

PHP not working if filters not set #148

noah-b opened this issue Dec 3, 2014 · 3 comments

Comments

@noah-b
Copy link

noah-b commented Dec 3, 2014

I get this when I try beautifying php?

Command failed: /bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile;[ -f ~/.bashrc ] && source ~/.bashrc;php_beautifier --input "/var/folders/t7/557hkz7s7zx4mxwcdb6j2y2r0000gn/T/input114113-1524-frs1i0" --output "/var/folders/t7/557hkz7s7zx4mxwcdb6j2y2r0000gn/T/114113-1524-o9gzvb" --filters "" --directory_filters "" /bin/sh: php_beautifier: command not found
Command failed: /bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile;[ -f ~/.bashrc ] && source ~/.bashrc;php_beautifier --input "/var/folders/t7/557hkz7s7zx4mxwcdb6j2y2r0000gn/T/input114113-1524-1j978vg" --output "/var/folders/t7/557hkz7s7zx4mxwcdb6j2y2r0000gn/T/114113-1524-1uotbir" --filters "" --directory_filters "" /bin/sh: php_beautifier: command not found

@Glavin001 Glavin001 added the bug label Dec 4, 2014
@Glavin001 Glavin001 self-assigned this Dec 4, 2014
@Glavin001
Copy link
Owner

This was a bug created after #107 was resolved. Typos at https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/php-beautify.coffee#L6-L14

It should not attempt to apply filters if there are none set. @aparedes has discovered this and is correct is suggesting that you set the Beautifier's PHP Filter and Directory Filters package settings. See #147 (comment)

Sorry for any inconvenience. I'll try to find time this weekend to patch this.

@noah-b
Copy link
Author

noah-b commented Dec 5, 2014

That's OK it works fine with everything else I work with and I can happily wait until the weekend.

@Glavin001 Glavin001 added this to the My Christmas List milestone Dec 27, 2014
@Glavin001 Glavin001 changed the title Not working with PHP PHP not working if filters not set Dec 27, 2014
@Glavin001
Copy link
Owner

Published to v0.17.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants