-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save on beautify refuses to fire unless manually done first #59
Comments
At first read it immediately struck me as an issue caused by using activation events (See 4271bfe ). However, if you say it just started happening within the last 24 hours then I am a little surprised. The activation events were so that the package would not load until initially called once (like you described), so therefore the load time is faster and offset to the time of the first beautify. However, this would of course mean that observers to events such as the save event would not be created until after that first beautify. So ideally, simply removing the activation event would solve this issue. |
That fixed it. Just removing the package.json item. Thanks! Personally speaking it doesn't add "too much" startup time. That's me coming over from using webstorm as an IDE though. "This package added 141ms to startup time." You've done a great job with this! |
Excellent. Glad to hear it worked!
And also in the future be doing some even more major refactoring and performance improvements. I believe I can keep the load time and general performance high while not using activationEvents and providing all of the functionality the users love. Thanks for your feedback! |
Published v0.6.2 with fix :). |
Issue:
saving on beautify is on yet when I save it does not beautify unless I used ctrl-alt-b first. This however prevents whitespace from ensuring a blank line at the end of the file.
Installed Packages:
I'm also using OSX Yosemite. Not sure if that matters but this started happening in last 24 hours and I went through my install history and can't figure out what could have caused it.
Is there any info I could provide?
The text was updated successfully, but these errors were encountered: