Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0421] Refactor #11

Closed
4 of 6 tasks
GleamingStar opened this issue Apr 21, 2021 · 0 comments · Fixed by #14
Closed
4 of 6 tasks

[0421] Refactor #11

GleamingStar opened this issue Apr 21, 2021 · 0 comments · Fixed by #14
Assignees
@GleamingStar
Labels
Seong assigned in seong
Milestone
1주차 금요일 데모

Comments

@GleamingStar
Copy link
Owner

GleamingStar commented Apr 21, 2021 •
edited
Loading

codesquad-members-2021#5

1차 PR 피드백 반영

대상

  • fetch부분 async로 -> 추후 main에서 BestList와 Article을 만들 때 적용
  • BestList
    • Tab map함수 부분 분리
  • Card
    • 프로퍼티
      • 네이밍 : 객체의 속성 이름을 어떻게 조정할까?
      • 개수 : 그냥 props로 할까
    • styled-component
      • 테마? LARGE, MEDIUM, SMALL
      • switch-case부분 들여쓰기
  • 공통
    • CSS color 단축 표기법
@GleamingStar GleamingStar added the Seong assigned in seong label Apr 21, 2021
@GleamingStar GleamingStar self-assigned this Apr 21, 2021
@GleamingStar GleamingStar mentioned this issue Apr 22, 2021
Merged
@GleamingStar GleamingStar linked a pull request Apr 22, 2021 that will close this issue
[0422] Refactor BestList, Badge, Card, Modal #14
Merged
@GleamingStar GleamingStar mentioned this issue Apr 23, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GleamingStar GleamingStar

Labels
Seong assigned in seong
Projects
None yet
Milestone
1주차 금요일 데모
Development

Successfully merging a pull request may close this issue.

[0422] Refactor BestList, Badge, Card, Modal GleamingStar/sidedish
1 participant
@GleamingStar