Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comex_fence_proc() is no-op in MT, PT, PR #56

Closed
jeffdaily opened this issue May 25, 2017 · 0 comments
Closed

comex_fence_proc() is no-op in MT, PT, PR #56

jeffdaily opened this issue May 25, 2017 · 0 comments
Assignees
Labels

Comments

@jeffdaily
Copy link
Member

TravisCI build was showing MPI-MT port to fail, but only occasionally. Upon further review,

int comex_fence_proc(int proc, comex_group_t group)
{
#if DEBUG
    printf("[%d] comex_fence_proc(proc=%d, group=%d)\n",
            g_state.rank, proc, group);
#endif

    comex_wait_all(COMEX_GROUP_WORLD);

    return COMEX_SUCCESS;
}

The call to comex_wait_all() is effectively a no-op in this case. No fencing message is initiated, so there is nothing to wait on. This is repeated in the PT and PR implementations. I wonder if we meant to call comex_fence_all() instead? It's potentially a heavy hammer, but it would work.

@jeffdaily jeffdaily self-assigned this May 25, 2017
@jeffdaily jeffdaily added the bug label May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant