Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en_US/Bundle.properties etc. for Dataverse 6.4 #125

Closed
pdurbin opened this issue Oct 21, 2024 · 5 comments
Closed

Update en_US/Bundle.properties etc. for Dataverse 6.4 #125

pdurbin opened this issue Oct 21, 2024 · 5 comments

Comments

@pdurbin
Copy link
Member

pdurbin commented Oct 21, 2024

Hello! First, thank you to all of you lovely translators who work so hard all the time on this repo! ❤️ ❤️ ❤️

I'm here to ask if en_US/Bundle.properties etc. can be updated for Dataverse 6.4. It would resolve an issue with deploying this pull request:

@JayanthyChengan you seem to have made these updates in recent months. If you or someone else could do your normal thing and update for 6.4, we'd appreciate it. No rush on this. Thanks!

@JayanthyChengan
Copy link
Collaborator

@pdurbin : Updated the property files under en_US from the latest develop branch of IQSS.

@pdurbin
Copy link
Member Author

pdurbin commented Nov 15, 2024

@JayanthyChengan I see. In 965514e. Perfect, thanks!

I'll go ahead and close this issue but we were wondering... is it helpful if the person doing the Dataverse release creates an issue like this? We recently updated our "making releases" procedure in IQSS/dataverse#10932 but we could make another PR adding a step like "create an issue in the language pack repo to update for the new release".

For my reference, here's the Slack conversation.

I can say more about our troubles with staticSearchFields.properties with 6.4 if you're interested. 😅

Thanks again!

@pdurbin pdurbin closed this as completed Nov 15, 2024
@JayanthyChengan
Copy link
Collaborator

@pdurbin : Yes, please create an issue for future release, and I will take care of it.

@pdurbin
Copy link
Member Author

pdurbin commented Nov 15, 2024

@JayanthyChengan ok, will do! Thanks!

@pdurbin
Copy link
Member Author

pdurbin commented Nov 18, 2024

I'm adding a step to our "making releases" process:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants