Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sample configuration should use standard naming #21

Open
ossdhaval opened this issue Aug 9, 2024 · 4 comments
Open

fix: sample configuration should use standard naming #21

ossdhaval opened this issue Aug 9, 2024 · 4 comments
Assignees

Comments

@ossdhaval
Copy link
Contributor

ossdhaval commented Aug 9, 2024

The sample configuration downloaded using TUI for agama-pw flow uses temporary name for flow name. This should be avoided.

To get the file:

  1. Open TUI
  2. Upload agama-pw project (rel: 1.0.1)
  3. Once the project gets uploaded without errors, select the project and press c
  4. Select download sample configuration

image

@mmrraju
Copy link
Collaborator

mmrraju commented Aug 9, 2024

Please check with latest release v1.0.2 .

@ossdhaval
Copy link
Contributor Author

Hi @mmrraju

Yes, I can see the changes in the sample file content but I would like to know why there are two top level elements in the sample JSON.

The sample config that I downloaded has the below content:

{
  "": {},
  "org.gluu.agama.pw.main": {}
}

While the README config section shows only one.

Can you bring these two in synch?

@mmrraju
Copy link
Collaborator

mmrraju commented Aug 12, 2024

@syntrydy , could you please help on this?

@ossdhaval
Copy link
Contributor Author

@syntrydy @mmrraju Let's get this to completion. Like in other projects(see sample conf of agama-sms or totp), the content of sample should be meaningful. Like what is in the readme here.

@syntrydy syntrydy self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants