feat: adjust ownership and permission to avoid bloated images (#219) #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iromli
added
kind-enhancement
moabu
requested changes
May 14, 2022
docker-casa/Dockerfile
Outdated
| @@ -199,7 +199,8 @@ ENV CN_MAX_RAM_PERCENTAGE=75.0 \ | |||
| CN_JAVA_OPTIONS="" \ | |||
| CN_SSL_CERT_FROM_SECRETS=false \ | |||
| GOOGLE_PROJECT_ID="" \ | |||
| GOOGLE_APPLICATION_CREDENTIALS=/etc/jans/conf/google-credentials.json | |||
| GOOGLE_APPLICATION_CREDENTIALS=/etc/jans/conf/google-credentials.json \ | |||
| CN_CASA_ADMIN_LOCK_FILE=/opt/jans/jetty/casa/resources/.administrable | |||
There was a problem hiding this comment.
We should add this env to the readme env section
There was a problem hiding this comment.
Noted. Also, we need to change the env name to GLUU_CASA_ADMIN_LOCK_FILE to align with the image specific env vars (i.e. GLUU_CASA_APP_LOGGERS).
|
[casa-base] Kudos, SonarCloud Quality Gate passed!
|
moabu
approved these changes
May 16, 2022
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset adjust ownership and permission as mentioned in #219