Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML: Configure SP's without Metadata #1601

Closed
nynymike opened this issue Apr 4, 2019 · 8 comments
Closed

SAML: Configure SP's without Metadata #1601

nynymike opened this issue Apr 4, 2019 · 8 comments
Assignees
Labels
SAML SAML Related Issue
Milestone

Comments

@nynymike
Copy link
Contributor

nynymike commented Apr 4, 2019

Some SP's have no metadata--they just publish the certificate and ACS url. Currently we make the admin create an XML file and upload it. It would be better if we create a new SP type called manual, and display a form where the admin could enter the information. Perhaps we can render an XML file?

@malotian
Copy link
Contributor

Kindly refer https://www.samltool.com/sp_metadata.php, and create a similar form

@yurem yurem added this to the 4.1 milestone May 21, 2019
@yuriyz yuriyz modified the milestones: 4.1, 4.2 Dec 12, 2019
@nynymike nynymike added the SAML SAML Related Issue label Jan 20, 2020
@syntrydy syntrydy assigned syntrydy and unassigned syntrydy May 28, 2020
@shmorri shmorri modified the milestones: 4.2, 4.3 Jun 11, 2020
@syntrydy syntrydy modified the milestones: 4.3, 5.0 Jul 22, 2020
@nynymike nynymike assigned shekhar16 and unassigned malotian Mar 24, 2022
@yurem
Copy link
Contributor

yurem commented May 11, 2022

We have conflict here in another issue about this functionality.
@nynymike Is this functionality needed?

@nynymike
Copy link
Contributor Author

These are two different features. "Generate SP" metadata rendered Shib SP config... we don't need that anymore. This feature is about giving the IDP admin an alternative to uploading SP metadata. If we have a form, we can ask for the info needed and just generate the metadata for the customer.

@yurem
Copy link
Contributor

yurem commented May 11, 2022

Thank you for explanation, now the difference is clear. @shekhar16 we also need to check if we cleaned up java code and velocity template(s) in issue (#2043). I think we just removed Generate SP metadata from GUI

@nynymike
Copy link
Contributor Author

That name was wrong... it wasn't actually SP metadata... it was SP Config. But what we need for this option is a form that enables the IDP admin to enter the entityID, the public cert of the SP, and the ACS endpoint URL. I might be missing something, but I think that's all we really need for a basic SAMLSSO config. @uprightech would know better.

@shekhar16
Copy link
Collaborator

image

@shekhar16
Copy link
Collaborator

@MohitMaliFtechiz please close this ticket

@shekhar16
Copy link
Collaborator

@MohitMaliFtechiz this issue already fixed and we tested it on 4.4.1 also,
closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SAML SAML Related Issue
Projects
None yet
Development

No branches or pull requests

7 participants