Remove minimum character requirement from sector uri client search form

[nynymike]

On the https:///identity/sectoridentifier/manage/add

Hitting search is ok, but should be limited to 20 results.

[shekhar16]

Fixed : Removed no of character validations and set limit of display search client result.

[yurem]

I think according to issue description we should keep input validation: 2-30 characters. But limit result set to 20 results.

Hitting search is ok, but should be limited to 20 results.

Also I think you can remove lines 264-266:
6218bc8#diff-63759ce348cbb0a769fa7c3fcc2152abR264

Method uses searchClients(String pattern, int sizeLimit) second param wich tell LDAP to return max number of results.

[shekhar16]

Yes Yuriy ,I already tried with this approach but the display list is not restricted to expected limit, After that i fixed issue with different approach.(which is currently committed in repo.).
I reviewed that searchclient method and it was returning expected limited result but after that in do-while it will increase the result size and exceed the limit.And finally on display the list exceed the size limit.

[shekhar16]

As per issue heading "Remove minimum character requirement from sector uri client search form"
I removed the character validation.

[yurem]

If LDAP API not working fine we need to open issue to find out core of the issue.
LdapEntryManager.findEntries(String baseDN, Class entryClass, Filter filter, int sizeLimit)
Should return maximum specified number of entries if sizeLimit > 0

[yurem]

Regarding subject of this issue. I think we need to remove only minimum characters validation. Maxim validation should works as before.

@nynymike Can you clarify requirements

[yurem]

@shekhar16 I understand what you wrote about LdapEntryManager.findEntries with sizeLimit

In oxLdap name of the parameter not conform to actual action..

I updated oxLdap. I renamed:
sizeLimit -> searchLimit

And added:
sizeLimit parameter to allow specify how many entries LDAP should return. Now when we do search we do next:

searchRequest.setSizeLimit(sizeLimit);


These are new changes:
GluuFederation/oxCore@e8ebc63#diff-794d10d8e9dc72141ca737ff12142343R213

[yurem]

@shekhar16 can you try to use new method:
findEntries(String baseDN, Class entryClass, Filter filter, int searchLimit, int sizeLimit)

searchLimit = 0 to not use pagination during search

[yurem]

I offer to close it.

I updated validation: a1ef436

And now we uses LDAP to limit search limit