Skip to content

Commit f617cad

Browse files
corona10Glyphack
authored andcommitted
pythongh-111968: Unify freelist naming schema to Eric's suggestion (pythongh-114581)
1 parent 0db8dab commit f617cad

File tree

8 files changed

+25
-25
lines changed

8 files changed

+25
-25
lines changed

Include/internal/pycore_freelist.h

+7-7
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,13 @@ struct _Py_object_stack_state {
103103
};
104104

105105
typedef struct _Py_freelist_state {
106-
struct _Py_float_state float_state;
107-
struct _Py_tuple_state tuple_state;
108-
struct _Py_list_state list_state;
109-
struct _Py_slice_state slice_state;
110-
struct _Py_context_state context_state;
111-
struct _Py_async_gen_state async_gen_state;
112-
struct _Py_object_stack_state object_stack_state;
106+
struct _Py_float_state floats;
107+
struct _Py_tuple_state tuples;
108+
struct _Py_list_state lists;
109+
struct _Py_slice_state slices;
110+
struct _Py_context_state contexts;
111+
struct _Py_async_gen_state async_gens;
112+
struct _Py_object_stack_state object_stacks;
113113
} _PyFreeListState;
114114

115115
#ifdef __cplusplus

Objects/floatobject.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ get_float_state(void)
3232
{
3333
_PyFreeListState *state = _PyFreeListState_GET();
3434
assert(state != NULL);
35-
return &state->float_state;
35+
return &state->floats;
3636
}
3737
#endif
3838

@@ -1993,7 +1993,7 @@ void
19931993
_PyFloat_ClearFreeList(_PyFreeListState *freelist_state, int is_finalization)
19941994
{
19951995
#ifdef WITH_FREELISTS
1996-
struct _Py_float_state *state = &freelist_state->float_state;
1996+
struct _Py_float_state *state = &freelist_state->floats;
19971997
PyFloatObject *f = state->free_list;
19981998
while (f != NULL) {
19991999
PyFloatObject *next = (PyFloatObject*) Py_TYPE(f);

Objects/genobject.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -1633,7 +1633,7 @@ static struct _Py_async_gen_state *
16331633
get_async_gen_state(void)
16341634
{
16351635
_PyFreeListState *state = _PyFreeListState_GET();
1636-
return &state->async_gen_state;
1636+
return &state->async_gens;
16371637
}
16381638
#endif
16391639

@@ -1659,7 +1659,7 @@ void
16591659
_PyAsyncGen_ClearFreeLists(_PyFreeListState *freelist_state, int is_finalization)
16601660
{
16611661
#ifdef WITH_FREELISTS
1662-
struct _Py_async_gen_state *state = &freelist_state->async_gen_state;
1662+
struct _Py_async_gen_state *state = &freelist_state->async_gens;
16631663

16641664
while (state->value_numfree > 0) {
16651665
_PyAsyncGenWrappedValue *o;

Objects/listobject.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ get_list_state(void)
2626
{
2727
_PyFreeListState *state = _PyFreeListState_GET();
2828
assert(state != NULL);
29-
return &state->list_state;
29+
return &state->lists;
3030
}
3131
#endif
3232

@@ -124,7 +124,7 @@ void
124124
_PyList_ClearFreeList(_PyFreeListState *freelist_state, int is_finalization)
125125
{
126126
#ifdef WITH_FREELISTS
127-
struct _Py_list_state *state = &freelist_state->list_state;
127+
struct _Py_list_state *state = &freelist_state->lists;
128128
while (state->numfree > 0) {
129129
PyListObject *op = state->free_list[--state->numfree];
130130
assert(PyList_CheckExact(op));

Objects/sliceobject.c

+7-7
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ PyObject _Py_EllipsisObject = _PyObject_HEAD_INIT(&PyEllipsis_Type);
106106
void _PySlice_ClearCache(_PyFreeListState *state)
107107
{
108108
#ifdef WITH_FREELISTS
109-
PySliceObject *obj = state->slice_state.slice_cache;
109+
PySliceObject *obj = state->slices.slice_cache;
110110
if (obj != NULL) {
111-
state->slice_state.slice_cache = NULL;
111+
state->slices.slice_cache = NULL;
112112
PyObject_GC_Del(obj);
113113
}
114114
#endif
@@ -132,9 +132,9 @@ _PyBuildSlice_Consume2(PyObject *start, PyObject *stop, PyObject *step)
132132
PySliceObject *obj;
133133
#ifdef WITH_FREELISTS
134134
_PyFreeListState *state = _PyFreeListState_GET();
135-
if (state->slice_state.slice_cache != NULL) {
136-
obj = state->slice_state.slice_cache;
137-
state->slice_state.slice_cache = NULL;
135+
if (state->slices.slice_cache != NULL) {
136+
obj = state->slices.slice_cache;
137+
state->slices.slice_cache = NULL;
138138
_Py_NewReference((PyObject *)obj);
139139
}
140140
else
@@ -370,8 +370,8 @@ slice_dealloc(PySliceObject *r)
370370
Py_DECREF(r->stop);
371371
#ifdef WITH_FREELISTS
372372
_PyFreeListState *state = _PyFreeListState_GET();
373-
if (state->slice_state.slice_cache == NULL) {
374-
state->slice_state.slice_cache = r;
373+
if (state->slices.slice_cache == NULL) {
374+
state->slices.slice_cache = r;
375375
}
376376
else
377377
#endif

Objects/tupleobject.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1125,7 +1125,7 @@ tuple_iter(PyObject *seq)
11251125
* freelists *
11261126
*************/
11271127

1128-
#define STATE (state->tuple_state)
1128+
#define STATE (state->tuples)
11291129
#define FREELIST_FINALIZED (STATE.numfree[0] < 0)
11301130

11311131
static inline PyTupleObject *

Python/context.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ static struct _Py_context_state *
6969
get_context_state(void)
7070
{
7171
_PyFreeListState *state = _PyFreeListState_GET();
72-
return &state->context_state;
72+
return &state->contexts;
7373
}
7474
#endif
7575

@@ -1270,7 +1270,7 @@ void
12701270
_PyContext_ClearFreeList(_PyFreeListState *freelist_state, int is_finalization)
12711271
{
12721272
#ifdef WITH_FREELISTS
1273-
struct _Py_context_state *state = &freelist_state->context_state;
1273+
struct _Py_context_state *state = &freelist_state->contexts;
12741274
for (; state->numfree > 0; state->numfree--) {
12751275
PyContext *ctx = state->freelist;
12761276
state->freelist = (PyContext *)ctx->ctx_weakreflist;

Python/object_stack.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ static struct _Py_object_stack_state *
1212
get_state(void)
1313
{
1414
_PyFreeListState *state = _PyFreeListState_GET();
15-
return &state->object_stack_state;
15+
return &state->object_stacks;
1616
}
1717

1818
_PyObjectStackChunk *
@@ -76,7 +76,7 @@ _PyObjectStackChunk_ClearFreeList(_PyFreeListState *free_lists, int is_finalizat
7676
return;
7777
}
7878

79-
struct _Py_object_stack_state *state = &free_lists->object_stack_state;
79+
struct _Py_object_stack_state *state = &free_lists->object_stacks;
8080
while (state->numfree > 0) {
8181
_PyObjectStackChunk *buf = state->free_list;
8282
state->free_list = buf->prev;

0 commit comments

Comments
 (0)