Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reproduce the results from the paper - Problem with InPlaceABNSync? #88

Open
alexandrewillame opened this issue Feb 2, 2024 · 1 comment

Comments

@alexandrewillame
Copy link

alexandrewillame commented Feb 2, 2024

I cannot reproduce the results from the paper. I suspect it is a problem with the InPlaceABNSync function.

The code as-is does not work on my computer (either on Windows 11 or WSL = Linux), some problem with Ninja / C++ compiling. I want to get rid of the code that uses Ninja which is the code of the InPlaceABNSync function.

I thus modified the AugmentCE2P to bypass InPlaceABNSync which is the module that uses Ninja/cpp functions.. I modified networks/AugmentCE2P.py, line 21 and 23:

from modules import InPlaceABNSync

BatchNorm2d = functools.partial(InPlaceABNSync, activation='none')

I deleted these lines and replaced them by the following:

from torch.nn import BatchNorm2d
def InPlaceABNSync(input):
    return BatchNorm2d(input)

Thus supposedly using the standard torch BatchNorm2d instead of the InPlaceABNSync version, assuming InPlaceABNSync is just a BatchNorm2d function with no activation layer.

The code run without error, but if we take the demo example (demo/demo.jpg) using the lip dataset using the latest checkpoint (exp-schp-201908261155-lip.pth)t, it is far from what is expected:

image

Instead of:

image

The source image is indeed exactly the same, there is thus a difference somewhere in the code.

Can somebody help / show how to make the code work properly without the use of InPlaceABNSync?

Thank you,

@madanmanit
Copy link

Did you find a solution? I too am using a windows 11 env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants