Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the input textbox vertical in pyrdp-player #210

Closed
Res260 opened this issue Apr 9, 2020 · 3 comments
Closed

Make the input textbox vertical in pyrdp-player #210

Res260 opened this issue Apr 9, 2020 · 3 comments
Labels

Comments

@Res260
Copy link
Collaborator

Res260 commented Apr 9, 2020

With #208, putting the textbox vertical and on the right would use space more efficiently because most screens are 16:9 and some vertical space must be used by the player, this will most times leave empty space on the right:

image

It also makes more sense since the data in it tends not to be large but long.

Thoughts?

@Res260 Res260 added the idea label Apr 9, 2020
@Res260
Copy link
Collaborator Author

Res260 commented Apr 9, 2020

thanks to my boy MSPaint here is a preview of the expected layout:
image

@alxbl
Copy link
Collaborator

alxbl commented Apr 9, 2020

It makes sense to have it vertical, since it's easier to have a widescreen aspect ratio. Feel free to prototype it and open a PR.

@alxbl
Copy link
Collaborator

alxbl commented Aug 6, 2020

We do not have the bandwidth for this. I'm going to close the issue to clean up the backlog, but if you end up implementing this, a PR is more than welcome, at which point you can link it with this issue and we can re-open until the PR is merged. I'll leave the idea tag on so that it can be easily searched for in the issue tracker.

@alxbl alxbl closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants