Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mod element doesn't work #434

Open
3 tasks done
RealSkullface opened this issue Jul 4, 2023 · 7 comments
Open
3 tasks done

Feature mod element doesn't work #434

RealSkullface opened this issue Jul 4, 2023 · 7 comments
Labels
bug Something isn't working Needs testing This issue needs to be tested.

Comments

@RealSkullface
Copy link

Issue description

I was made feature elements and it compiled, but the features didn't generate in the game. I tried to add more and less conditions, made them not biome specific, used templates and tried deleting the "build" folder, but nothing worked. Everything's still normal with the only issue that the features don't generate.

How to reproduce this issue?

Step 1: Create a workspace or open one.
Step 2: Create a feature modand apply a template.
Step 3: Save and run minecraft.
Step 4: Create a new world, the features won't be there.

Operating system

Windows

Details

MCreator version: 2023.2
Plugin version: 1.9.5
Generator: Fabric 1.20.1
Other plugins were not included.

Example workspace

bruh_mod.zip

Logs

No response

Issue tracker rule checks (please read carefully)

@RealSkullface RealSkullface added the bug Something isn't working label Jul 4, 2023
@Goldorion
Copy link
Owner

Goldorion commented Jul 4, 2023

The fix will only be possible when something inside MCreator's code will be fixed (it's due to a behaviour of MCreator). However, you can bypass the problem currently, by adding a procedure returning true for the Additional generation condition procedure selector.

@sdrowan123
Copy link

sdrowan123 commented Jul 18, 2023

@Goldorion this still isn't working for me. Anyone have any other workarounds? I'm happy to go into the code as well.

Untitled

Oddly enough I can see the generation is slower, as if it's trying to spawn the feature but doesn't. I'm using the 1.19.2 generator.

@sdrowan123
Copy link

I was able to fix this by replacing NoOpFeature and NoneFeatureConfiguration in my feature class with a relevant configuration. For me ReplaceBlobsFeature and ReplaceSphereConfiguration.

@Goldorion Goldorion added the Needs testing This issue needs to be tested. label Mar 15, 2024
@Goldorion
Copy link
Owner

Goldorion commented Mar 15, 2024

Is it still happening with the last updates?

@ravenkhor
Copy link

ravenkhor commented Apr 25, 2024

This is still happening in 2023.4, at least with custom-built trees. The .nbt models generate just fine with the structures element, but not the feature element.

@Goldorion
Copy link
Owner

Latest version?

@ravenkhor
Copy link

ravenkhor commented Apr 26, 2024

Version 1.10 of the plugin, for 1.20.1, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs testing This issue needs to be tested.
Projects
None yet
Development

No branches or pull requests

4 participants