Skip to content

Commit dff12e7

Browse files
committed
feat(UMetrics): add prefix and nodejsMetricsEnabled options to facade
1 parent f1256ff commit dff12e7

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

Diff for: src/UMetrics.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,18 @@ import Transport from './transport/Transport';
77
* @property {MetricRegistry} registry
88
*/
99
class UMetrics {
10-
constructor(transport, { prefix, labels } = {}) {
10+
constructor(
11+
transport,
12+
{ prefix = null, labels, nodejsMetricsEnabled = false } = {},
13+
) {
1114
if (!transport || !(transport instanceof Transport)) {
1215
throw new Error(
1316
'Transport must be provided and be instance of Transport',
1417
);
1518
}
1619

20+
this.nodejsMetricsEnabled = nodejsMetricsEnabled;
21+
this.prefix = prefix;
1722
this.transport = transport;
1823
this.registry = new MetricRegistry({
1924
prefix,

Diff for: src/UMetrics.server.test.js

+18
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,22 @@ describe('UMetrics facade', () => {
3131
const realMetric = uMetrics.register(uMetrics.Metrics.Gauge, 'testMetric');
3232
expect(uMetrics.testMetric).to.be.equals(realMetric);
3333
});
34+
35+
it('Should have defaultMetrics disabled by default', () => {
36+
const uMetrics = new UMetrics(new Transport(), { port: 1111 });
37+
expect(uMetrics.nodejsMetricsEnabled).to.be.false;
38+
});
39+
40+
it('Should have metricsPrefix options null by default', () => {
41+
const uMetrics = new UMetrics(new Transport(), { port: 1111 });
42+
expect(uMetrics.prefix).to.be.null;
43+
});
44+
45+
it('Should change metricsPrefix options', () => {
46+
const uMetrics = new UMetrics(new Transport(), {
47+
port: 1111,
48+
prefix: 'test',
49+
});
50+
expect(uMetrics.prefix).to.be.equals('test');
51+
});
3452
});

0 commit comments

Comments
 (0)