Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds conditional logic for remote docker in tests #71

Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat: Adds conditional logic for remote docker in tests #71

merged 1 commit into from
Jul 17, 2023

Conversation

jeffcap1
Copy link
Contributor

Description

Updated the test commands to have a new flag for when it should use the setup_remote_docker. By default, this is disabled as in most cases it is not necessary.

@jeffcap1 jeffcap1 added the feature New feature or request label Jun 28, 2023
@jeffcap1 jeffcap1 self-assigned this Jun 28, 2023
mattfraz
mattfraz approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@mattfraz mattfraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jeffcap1 jeffcap1 merged commit 110762c into master Jul 17, 2023
@jeffcap1 jeffcap1 deleted the feat/conditional-remote-docker branch July 17, 2023 21:05
bnormington pushed a commit that referenced this pull request Jul 18, 2023
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
6fc6119 
# [2.6.0](v2.5.0...v2.6.0) (2023-07-18)

### Bug Fixes

* adding the --force npm flag to overcome version conflicts ([#73](#73)) ([20da3e4](20da3e4))

### Features

* Adds conditional logic for remote docker in tests ([#71](#71)) ([110762c](110762c))
@bnormington
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfraz mattfraz mattfraz approved these changes

@mrcrawfo mrcrawfo Awaiting requested review from mrcrawfo

@jpiepkow jpiepkow Awaiting requested review from jpiepkow

@bnormington bnormington Awaiting requested review from bnormington

@cameron-carruthers cameron-carruthers Awaiting requested review from cameron-carruthers

@AndrewSamaha AndrewSamaha Awaiting requested review from AndrewSamaha

Assignees

@jeffcap1 jeffcap1

Labels
feature New feature or request released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffcap1 @bnormington @mattfraz