New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for successful typecheck from dependent module #83

Open

paulirish opened this issue Jan 9, 2018 · 1 comment

Member

paulirish commented Jan 9, 2018 •

edited

Loading

A test for #81

see also GoogleChrome/lighthouse#4192 (comment)

i was thinking a more functional test. e.g. some module that require()s chrome-launcher successfully typechecks with TS.

paulirish mentioned this issue

deps(chrome-launcher): Upgrade chrome-launcher GoogleChrome/lighthouse#4192

Merged

Member Author

paulirish commented Jan 10, 2018

I attempted this in a branch: https://github.com/GoogleChrome/chrome-launcher/compare/fixtstypingsattempt

however i can't get this 'Could not find a declaration file' error. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment