Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to ignore query string on static resources #215

Closed
olsh opened this issue Feb 17, 2020 · 2 comments
Closed

Add an option to ignore query string on static resources #215

olsh opened this issue Feb 17, 2020 · 2 comments
Labels

Comments

@olsh
Copy link

olsh commented Feb 17, 2020

We update the query string for each build for if the content of a static file was changed.
For instance, if the content of styles.css?v=1 was updated, we update the query string, like this styles.css?v=2.

In this case, the lighthouse server considers these files as entirely different and produces many unnecessary differences on the compare page. Please see the attached.

image
image

It would be nice to have an option to ignore query strings for such cases.

@patrickhulce
Copy link
Collaborator

Great request @olsh! That would indeed be annoying if the query string doesn't change things 👍 We're working on bringing more customization to how this is handled too #154

@patrickhulce
Copy link
Collaborator

query strings will now be ignored in 0.4.0, fixed by #318, ref #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants