Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Stackpack: Incorrect advice to run AMP Optimizer on AMP pages which are already optimized #10045

Closed
westonruter opened this issue Nov 28, 2019 · 2 comments

Comments

@westonruter
Copy link

When running Lighthouse on an AMP page being served from the Cache, which is already serving Optimized AMP, the AMP stackpack is nevertheless suggesting to use the AMP Optimizer:

image

So this is not good advice because running the AMP Optimizer will have no effect since it is already optimized.

This stackpack suggestion for AMP should not be offered when the html element has the transformed attribute present.

Provide the steps to reproduce

  1. Run LH performance audit on https://elsoberano-org.cdn.ampproject.org/c/s/elsoberano.org/constitucion/denuncian-que-walmart-esta-pidiendo-mas-represion-para-proteger-sus-ganancias/

This is the optimized AMP Cache version of https://elsoberano.org/constitucion/denuncian-que-walmart-esta-pidiendo-mas-represion-para-proteger-sus-ganancias/

What is the current behavior?

On an optimized AMP page, Lighthouse is advising: “Use tools such as AMP Optimizer to server-side render AMP layouts.”

What is the expected behavior?

No such advice should be offered.

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: 5.7.0
  • Chrome version: 80.0.3977.4 (Official Build) canary (64-bit)
  • Operating System: MacOS
@westonruter westonruter changed the title AMP Stackpack: AMP Stackpack: Incorrect advice to run AMP Optimizer on AMP pages which are already optimized Nov 28, 2019
@connorjclark
Copy link
Collaborator

This is WAI unfortunately, I don't think we've discussed detecting the tools suggested in stack packs. At the moment stack-specific advice is always given when a specific stack is detected.

@patrickhulce
Copy link
Collaborator

This is the same root issue as #2832 and should be resolved when the proposed solution is implemented. De-duping into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants