Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused extendedInfo field from audits #10567

Closed
Beytoven opened this issue Apr 9, 2020 · 1 comment · Fixed by #10779
Closed

Remove unused extendedInfo field from audits #10567

Beytoven opened this issue Apr 9, 2020 · 1 comment · Fixed by #10779
Assignees
Labels

Comments

@Beytoven
Copy link
Contributor

Beytoven commented Apr 9, 2020

A handful of audits are still setting the extendedInfo in their return value. Since extendedInfo has been wholly replaced by 'details' and 'debugData', it's no point in keeping it since it doesn't even make it into the LHR json.

@paulirish
Copy link
Member

the legacy JS audit can move from extendedInfo to the debugData & table pattern that we see in axe-audit.

many of the rest i quickly saw are already captured in details.
if there's any that aren't, we'll need to figure out how to handle those.

and yah i saw some tests that'll need updates, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants