Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axe-core: update and evaluate all the enabled checks #11643

Closed
paulirish opened this issue Nov 9, 2020 · 5 comments
Closed

axe-core: update and evaluate all the enabled checks #11643

paulirish opened this issue Nov 9, 2020 · 5 comments

Comments

@paulirish
Copy link
Member

paulirish commented Nov 9, 2020

axe 4.0!

also remove video-description, etc. #10128


see last times we did this:

@patrickhulce
Copy link
Collaborator

Let's double check that #11649 is fixed by updating to axe 4 once this is done, if not we can reopen that issue :)

@connorjclark
Copy link
Collaborator

image

yayyyyy this gonna be fun

maybe will add a new build step to transpile this to commonjs, keep in third_party

actually this would be better: let's merge #11442, so we don't import this file directly from source.

@brendankenny
Copy link
Member

for importing es modules into commonjs, need to use import(), not require():

https://nodejs.org/api/esm.html#esm_interoperability_with_commonjs

@brendankenny
Copy link
Member

(this can be annoying, however, because then it has to be async)

@connorjclark
Copy link
Collaborator

closed by #11661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants