Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] V2 Report Burndown #1887

Closed
10 of 12 tasks
paulirish opened this issue Mar 21, 2017 · 4 comments
Closed
10 of 12 tasks

[meta] V2 Report Burndown #1887

paulirish opened this issue Mar 21, 2017 · 4 comments
Assignees

Comments

@paulirish
Copy link
Member

paulirish commented Mar 21, 2017

Overview

Report sprint

  • Add report DOM renderer MVP [@dgozman]
    • Re-sort topics by failures [@robdodson]
    • Hide passing audits [@ebidel]
    • Render Markdown to DOM [@brendankenny]
    • Migrating various formatters to DOM [team]

Audit IA refactor

PWA definition - Align PWA items w/ Checklist [@ebidel]

  • add TTI < 10s audit [@paulirish]
  • Add placeholders for crossbrowser, etc
  • Express PWA boolean along with score (decide how score and boolean relate)
@wardpeet
Copy link
Collaborator

wardpeet commented Mar 22, 2017

if it helps I can make the report's styling cross browser ^^

@ebidel
Copy link
Contributor

ebidel commented Mar 22, 2017

@paulirish since we can't test the additional PWA checklist items, do we need fake audits for them (crossbrowser, each page has an url, page transitions dont fee janky)? There's already a note at the top of the section that says our items are a subset of the checklist and links to it:

screen shot 2017-03-22 at 4 51 21 pm

@paulirish
Copy link
Member Author

@ebidel not sure! we could do fake audits (a la comingSoon) or some paragraph text at the end of the section, or something else. The paragraph text doesn't sound so bad to me.

For expressing the PWA boolean I think we should plan on showing like a green checkmark if you're good. So maybe something like

Congrats, you're bonafide!

You've met the requirements for a baseline progressive web app*.

*Baseline PWAs require a few criteria that Lighthouse didn't test. 1) The site must work crossbrowser. 2) Each page must have a URL. 3) Transitions between pages dont feel janky. Read more here.

Just spitballing, so whatever. :)

@paulirish
Copy link
Member Author

closing in favor of the io burndown issue. #1937

i filed the new #2059 to capture our convo here about the untested PWA reqs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants