intermittent travis failures on "could not handle JavaScript dialog"

[brendankenny]

This is from the smoke test introduced in #2120. handleJavaScriptDialog

Behavior seems to be it fails, the promise rejection is unhandled (intentionally), then the test sits there and spins until travis hits its 10 minute timeout.

I'm not sure how the protocol is failing to dismiss the dialog (and only on travis? or are we just not running yarn smoke enough locally?), but the only solution I know of right now is removing the window.confirm from dbw_tester, which would be unfortunate.

Any other ideas?

[patrickhulce]

😢 if there's not a simple timeout/polling-like fix then I'm in favor of removing, we don't need to introduce even more noise to our travis runs in addition to screenshots... :/

[brendankenny]

ideally the real fix would be figuring out why the protocol can't dismiss a modal.

Agreed on the no-(new-)flakiness, but this would be a good thing to automatically not regress on. Most sites that we test normally don't do modal prompts.