Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure the execution time of each task more accurately #2304

Closed
patrickhulce opened this issue May 18, 2017 · 4 comments · Fixed by #3745
Closed

Measure the execution time of each task more accurately #2304

patrickhulce opened this issue May 18, 2017 · 4 comments · Fixed by #3745

Comments

@patrickhulce
Copy link
Collaborator

Right now some audits that request computed artifacts are before the audit that most clearly identifies what's being computed (loadfast4pwa uses first interactive and looks like it takes a very long time while first interactive later appears to be very fast since it's using the now cached result.

@kscm
Copy link

kscm commented May 21, 2017

Since v2.0.0, performance measures are baffling, like here:
Consistently Interactive 850ms, but registering First meaningful paint 851.9ms

First meaningful paint 851.9ms
First Interactive (beta) 850ms
Consistently Interactive (beta) 850ms

And somehow the "850ms" ~ "1+ sec" I get as results don't really match what I see:
https://www.webpagetest.org/result/170521_31_TBB/

LH v1 was measuring those at about 250ms in the last tests.

Are those new values due to the same issue?

kinoseed.com_2017-05-21_19-56-32.json.zip

@benschwarz
Copy link
Contributor

I'm seeing this too on plenty of runs

@brendankenny
Copy link
Member

@kscm that sounds unrelated to the original post. This is talking about the wall clock time to compute an audit, not the time an audit measures. Would you mind filing a separate issue?

@paulirish paulirish changed the title Order audits so logging correctly attributes compute time Log the execution time of each log/task more accurately Sep 26, 2017
@patrickhulce
Copy link
Collaborator Author

@paulirish's awesome idea: put the timing of each audit and gatherer into the LHR's timing object

@paulirish paulirish changed the title Log the execution time of each log/task more accurately Measure the execution time of each task more accurately Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants